Skip to content

enable nightly tests#58

Merged
jameslamb merged 2 commits intomainfrom
enable-nightly-tests
Mar 3, 2026
Merged

enable nightly tests#58
jameslamb merged 2 commits intomainfrom
enable-nightly-tests

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Mar 3, 2026

Contributes to #13

Fixes nightly tests and enables the PR CI check that they've passed recently.

Notes for Reviewers

How I tested this

Triggered the tests on the branch from #56 : https://github.com/rapidsai/nvforest/actions/runs/22605703267/job/65497169515

All tests passed. The conda-python-tests jobs failed only because codecov isn't set up.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 3, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 3, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
script: "ci/test_python.sh"
run_codecov: false
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov isn't set up for this repo and I'm not sure if there are plans to.

warning - 2026-03-03 02:41:34,549 -- No config file could be found. Ignoring config.
debug - 2026-03-03 02:41:34,549 -- No codecov_yaml found

(build link)

Let's just skip it for now.

Comment thread .github/workflows/pr.yaml
with:
repo: ${{ github.repository }}
target-branch: ${{ fromJSON(steps.get-pr-info.outputs.pr-info).base.ref }}
max-days-without-success: 7
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail until we get #56 and this PR merged. I think in the interest of time, we should just admin-merge this after #56 if reviewers agree, then I can manually trigger a test run on main.

@jameslamb jameslamb changed the title WIP: enable nightly tests enable nightly tests Mar 3, 2026
@jameslamb jameslamb marked this pull request as ready for review March 3, 2026 15:37
@jameslamb jameslamb requested a review from a team as a code owner March 3, 2026 15:37
@jameslamb jameslamb requested a review from bdice March 3, 2026 15:37
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 223e8c0 and 3192c0a.

📒 Files selected for processing (2)
  • .github/workflows/pr.yaml
  • .github/workflows/test.yaml

📝 Walkthrough

Walkthrough

GitHub Actions workflow configurations are updated: a new check-nightly-ci job is added to the PR workflow with PR info fetching and nightly CI dispatch capabilities, and the test workflow is modified to disable codecov in the conda-python-tests invocation.

Changes

Cohort / File(s) Summary
PR workflow updates
.github/workflows/pr.yaml
Introduces new check-nightly-ci job that fetches PR metadata and dispatches nightly CI status checks. The pr-builder job now depends on this new job. Replaces previous commented block with actual job definition.
Test workflow configuration
.github/workflows/test.yaml
Adds run_codecov: false parameter to conda-python-tests workflow invocation to disable codecov-related steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jameslamb jameslamb merged commit 6e23cc9 into main Mar 3, 2026
58 of 60 checks passed
@jameslamb jameslamb deleted the enable-nightly-tests branch March 3, 2026 16:46
@jameslamb
Copy link
Copy Markdown
Member Author

nightly tests passed 😊

https://github.com/rapidsai/nvforest/actions/runs/22634081735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants