Use Specific CCCL Includes#2953
Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom Feb 18, 2026
Merged
Conversation
divyegala
added
improvement
aamijar
approved these changes
Feb 16, 2026
dantegd
reviewed
Feb 17, 2026
Member
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
Looks good, had one question in the comment and another here:
If a RAFT header that includes cub/device/* is pulled into a JIT-LTO TU in cuVS, we may still need to either avoid including that header in JIT TUs or rely on the existing EmptyKernel filtering. Would be worth a short note in the PR description and/or docs so future contributors know the intended interaction with JIT-LTO.
dantegd
approved these changes
Feb 18, 2026
Member
Author
|
/merge |
This was referenced Feb 18, 2026
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
Follow up to #2953 Fixes cuML cpp builds: https://github.com/rapidsai/cuml/actions/runs/22122335604/job/63945209952?pr=7814#step:11:1165 Authors: - Anupam (https://github.com/aamijar) Approvers: - Divye Gala (https://github.com/divyegala) URL: #2957
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Feb 18, 2026
Follow up to rapidsai/raft#2953. Fixes cuvs cpp builds: https://github.com/rapidsai/cuvs/actions/runs/22123036004/job/63947163979#step:11:2650 Authors: - Anupam (https://github.com/aamijar) Approvers: - Divye Gala (https://github.com/divyegala) URL: #1817
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
Follow up to #2954. #2954 broke raft and cuvs CI since the PR branch was a few commits behind main during the CI run which didn't catch the conflict caused by #2953 Authors: - Anupam (https://github.com/aamijar) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) URL: #2959
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed downstream because cub injects an
EmptyKernelsymbol into every TU that includes eithercub/cub.cuhorcub/device/*includes, and this causes an issue for cubins created using JIT-LTO.As such, when including RAFT headers in JIT TUs we must be mindful about not accidentally injecting
EmptyKernel.