Skip to content

fix conda uploads, use more rapids-dependency-file-generator#101

Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
jameslamb:more-dfg
May 29, 2025
Merged

fix conda uploads, use more rapids-dependency-file-generator#101
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
jameslamb:more-dfg

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented May 29, 2025

Follow-up to #99

Fixes the failing conda builds:

The workflow is not valid. .github/workflows/build.yaml (Line: 18, Col: 13): Job 'conda-python-build' depends on unknown job 'checks'. .github/workflows/build.yaml (Line: 25, Col: 13): Job 'upload-conda' depends on job 'conda-python-build' which creates a cycle in the dependency graph.

(build link)

Adds more use of rapids-dependency-file-generator for managing dependencies.

Also bumps the version to 0.1.2, to pick up the slight change to wheel metadata (importlib-metadata, not importlib_metadata: https://pypi.org/project/importlib-metadata/)

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 29, 2025
@jameslamb jameslamb changed the title WIP: fix conda uploads, use more rapids-dependency-file-generator fix conda uploads, use more rapids-dependency-file-generator May 29, 2025
@jameslamb jameslamb marked this pull request as ready for review May 29, 2025 15:24
@jameslamb jameslamb requested review from a team and ncclementi May 29, 2025 15:25
Copy link
Copy Markdown
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dependencies.yaml Outdated
@jameslamb
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 189e5c5 into rapidsai:main May 29, 2025
22 checks passed
@jameslamb jameslamb deleted the more-dfg branch May 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants