build and test wheels in CI#93
Closed
jameslamb wants to merge 9 commits into
Closed
Conversation
jameslamb
added
breaking
jameslamb
changed the title
jacobtomlinson
pushed a commit
that referenced
this pull request
May 22, 2025
Fixes #90 Replaces #93 *(was automatically closed by GitHub when we flipped the repo from private to public)* * adds wheels CI (for PRs and branch builds) * changes the distribution name from `rapids_cli` (underscore) to `rapids-cli` (hyphen), so the experience will be e.g. `pip install rapids-cli` * puts a floor on `setuptools`, to ensure builds always get a version that supports `pyproject.toml` * sets up tests to run on CI runners with GPUs - *I expect we'll want this as the test suite here is expanded* ## Notes for Reviewers ### Why use the RAPIDS calendar-versioned workflows? I think it's useful here to reuse all the RAPIDS machinery, especially artifact-handling and running tests on runners with GPUs. This project differs in this important way from other pure-Python, `main`-branch projects in RAPIDS like https://github.com/rapidsai/rapids-build-backend or https://github.com/rapidsai/rapids-metadata ... something like https://github.com/rapidsai/dask-cuda is probably a better reference for the testing needs for this project. Maybe we'll want to revisit this in the future as we see how often this project gets released relative to RAPIDS, but I think this is a good starting point for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
rapids_cli(underscore) torapids-cli(hyphen), so the experience will be e.g.pip install rapids-clisetuptools, to ensure builds always get a version that supportspyproject.tomlNotes for Reviewers
Why use the RAPIDS calendar-versioned workflows?
I think it's useful here to reuse all the RAPIDS machinery, especially artifact-handling and running tests on runners with GPUs.
This project differs in this important way from other pure-Python,
main-branch projects in RAPIDS like https://github.com/rapidsai/rapids-build-backend or https://github.com/rapidsai/rapids-metadata ... something like https://github.com/rapidsai/dask-cuda is probably a better reference for the testing needs for this project.Maybe we'll want to revisit this in the future as we see how often this project gets released relative to RAPIDS, but I think this is a good starting point for now.