Skip to content

Skipping unreliable tests#554

Merged
AyodeAwe merged 1 commit intobranch-25.10from
nirandaperera-patch-2
Oct 2, 2025
Merged

Skipping unreliable tests#554
AyodeAwe merged 1 commit intobranch-25.10from
nirandaperera-patch-2

Conversation

@nirandaperera
Copy link
Contributor

@nirandaperera nirandaperera commented Oct 1, 2025 •
edited
Loading

Related to #553

@nirandaperera nirandaperera requested a review from a team as a code owner October 1, 2025 19:57
@nirandaperera nirandaperera added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 1, 2025
wence-
wence- approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retarget to 25.10 and we will forward merge

@wence- wence- changed the base branch from branch-25.12 to branch-25.10 October 1, 2025 19:59
@wence- wence- requested review from a team as code owners October 1, 2025 19:59
@wence- wence- requested a review from bdice October 1, 2025 19:59
@nirandaperera nirandaperera changed the base branch from branch-25.10 to branch-25.12 October 1, 2025 20:00
@wence-
Copy link
Contributor

wence- commented Oct 1, 2025

Please rebase appropriately, I changed the bade branch

@nirandaperera
Copy link
Contributor Author

nirandaperera commented Oct 1, 2025

@wence- retargetting goes bonkers. 🙁

@nirandaperera nirandaperera changed the base branch from branch-25.12 to branch-25.10 October 1, 2025 20:01
@wence-
Copy link
Contributor

wence- commented Oct 1, 2025 •
edited
Loading

Rebase/cherry pick the one commit onto 25.10

@nirandaperera nirandaperera changed the base branch from branch-25.10 to branch-25.12 October 1, 2025 20:20
@nirandaperera
Copy link
Contributor Author

nirandaperera commented Oct 1, 2025

@wence- there are some 25.12 PRs missing in 25.10 branch. Especially #548. So, how should we approach this?

@nirandaperera
Copy link
Contributor Author

nirandaperera commented Oct 1, 2025

If I retarget this branch to 25.10, cherry pick #548 and current changes, then once this merges, #548 will be added to 25.12 again with the forward merge, isnt it?

@wence-
Copy link
Contributor

wence- commented Oct 1, 2025 •
edited
Loading

All we want to do in 25.10 is skip the tests. Your one commit does that, just sit it on top of 25.10

@wence-
Copy link
Contributor

wence- commented Oct 1, 2025

If we skip the tests for now we don't need #548 which it turns out didn't work anyway

@nirandaperera
Skipping tests
c3bde9f 
Signed-off-by: niranda perera <niranda.perera@gmail.com>
@nirandaperera nirandaperera force-pushed the nirandaperera-patch-2 branch from 5527c88 to c3bde9f Compare October 1, 2025 21:12
@nirandaperera nirandaperera changed the base branch from branch-25.12 to branch-25.10 October 1, 2025 21:13
@wence- wence- removed request for a team and bdice October 1, 2025 21:31
@AyodeAwe AyodeAwe merged commit c1bdf78 into branch-25.10 Oct 2, 2025
90 of 91 checks passed
@wence- wence- deleted the nirandaperera-patch-2 branch October 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madsbk madsbk madsbk approved these changes

@wence- wence- wence- approved these changes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nirandaperera @wence- @madsbk @AyodeAwe