Enable timeout with stack in CI#585
Conversation
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Mostly fine, but please move the gdb dependency to conda-only groups. I don't think you intended to have pip install gdb ever happen.
| - output_types: [conda, requirements, pyproject] | ||
| packages: | ||
| - cloudpickle | ||
| - gdb |
There was a problem hiding this comment.
These should be moved to conda-specific groups. There isn't a gdb project on PyPI.
It looks like the scripts you're modifying only affect tests that use the conda packages, but just in case I'm wrong about that... if you want gdb at test time for wheels, you'll need to add code to install it at test time for the wheel-based jobs with apt / dnf / yum.
There was a problem hiding this comment.
Absolutely, this was oversight by my part, should be fixed in 9ba818c. Thanks James for pointing it out.
There was a problem hiding this comment.
No problem, thanks for the fix.
|
No rush, but could you also admin merge this next week @jameslamb ? Thank you! |
|
Yes absolutely, keep |
2 participants
Additionally print the value of maximum number of pending connections (somaxconn) to help debug test issues with large number of simultaneous connections.