Merged
Conversation
…rvices packages - Updated project structure in dotnet.instructions.md to reflect new modular organization. - Added new helper methods for enabling and disabling fields in RowObject, FormObject, OptionObject, OptionObject2, and OptionObject2015. - Implemented unit tests for new helper methods in corresponding test projects. - Improved documentation in README files for RarelySimple.AvatarScriptLink.Objects and RarelySimple.AvatarScriptLink.Services to clarify usage and package recommendations. - Ensured compatibility with .NET Standard 2.0 and .NET 8.0 for respective projects.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the modular Objects.Helpers layer with new extension methods to enable/disable FieldObject instances across RowObject, FormObject, and the various OptionObject* models, while also updating repository/package documentation to reflect the newer modular package layout.
Changes:
- Added
SetDisabled*/SetEnabled*helper extensions forRowObject,FormObject,OptionObject,OptionObject2, andOptionObject2015. - Added/updated unit tests validating the new enable/disable behaviors across object types.
- Updated READMEs and contributor instructions to recommend modular packages (e.g.,
Objects.Helpers) vs the meta-package (Net).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/RarelySimple.AvatarScriptLink.Services/README.md | Updates package guidance to point users to Objects.Helpers or Net. |
| dotnet/RarelySimple.AvatarScriptLink.Objects/README.md | Clarifies Objects vs Helpers vs Net usage recommendations. |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs | Adds row-level enable/disable helpers (with RowAction side-effects). |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/FormObjectHelpers.cs | Adds form-level enable/disable helpers, including MI behavior. |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/OptionObjectHelpers.cs | Adds option-level enable/disable helpers by delegating to forms. |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/OptionObject2Helpers.cs | Adds option-level enable/disable helpers for OptionObject2. |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/OptionObject2015Helpers.cs | Adds option-level enable/disable helpers for OptionObject2015. |
| dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers.Tests/ExtensionMethodsTests.cs | Adds tests covering the new helper methods across objects. |
| .github/instructions/dotnet.instructions.md | Updates project list/docs for the modular Objects.* projects (contains new typos). |
| .github/copilot-instructions.md | Updates repository organization docs for modular Objects.* projects. |
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers.Tests/ExtensionMethodsTests.cs
Outdated
Show resolved
Hide resolved
…esponding unit tests
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers/RowObjectHelpers.cs
Outdated
Show resolved
Hide resolved
…logic - Created a comprehensive test suite for RowObjectHelpers, covering methods related to row and field manipulation. - Enhanced the logic in SetDisabledField and SetEnabledField methods to check if the field state has changed before modifying the RowAction. - Updated DisableAllFieldObjects and EnableAllFieldObjects methods to only set the RowAction if changes occur.
dotnet/RarelySimple.AvatarScriptLink.Objects.Helpers.Tests/OptionObjectHelpersTests.cs
Outdated
Show resolved
Hide resolved
…ionObjectHelpersTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
scottolsonjr
deleted the
169-implement-setdisabledfield-and-setenabledfield-methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and enhance the RarelySimple.AvatarScriptLink.Objects and Services packages