Skip to content

Fix #769 : Prevent double-wrapping of URLs in API generator#1149

Merged
rasbt merged 2 commits into
rasbt:masterfrom
N-Harsha-Vardhan-Dev:fix-769-broken-link
Jan 8, 2026
Merged

Fix #769 : Prevent double-wrapping of URLs in API generator#1149
rasbt merged 2 commits into
rasbt:masterfrom
N-Harsha-Vardhan-Dev:fix-769-broken-link

Conversation

@N-Harsha-Vardhan-Dev
Copy link
Copy Markdown
Contributor

Code of Conduct

Description

This PR fixes the logic in make_api.py that was causing URLs to be "double-wrapped" in Markdown brackets (e.g., [url](url)) on the documentation site. By adding a check in make_markdown_url, the generator now correctly ignores tokens that are already formatted as Markdown links, ensuring they render properly in the browser.

Related issues or pull requests

Fixes #769

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

Copy link
Copy Markdown
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@N-Harsha-Vardhan-Dev
Copy link
Copy Markdown
Contributor Author

Thank you for the review! Glad to help with this fix.

@rasbt rasbt merged commit f94e9e8 into rasbt:master Jan 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link not working

2 participants