Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# 0.41

* _Nothing yet_
* New: Default macOS platform target changed from `osx-x64` to `osx-arm64`
(Apple Silicon). Users on Intel Macs can still target `osx-x64` via
`--target-platform`
* Fix: GitHub release filename generation now supports ARM64 architecture,
preventing a crash when releasing ARM64 artifacts

# 0.40

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public async Task Run()
"golang-service");
AssertFileExists(
1L.MB(),
"osx-x64",
"osx-arm64",
"golang-service");
AssertFileExists(
1L.MB(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ private void AssertSuccessfulArtifacts()
AssertFileExists(
50L.MB(),
"bin", "Release", "publish", "win-x64", "NetCore.Console.exe");
AssertFileExists(
50L.MB(),
"bin", "Release", "publish", "osx-arm64", "NetCore.Console");
}

[TestCase(ExitCodes.Core.NoCommand)]
Expand Down
2 changes: 2 additions & 0 deletions Source/Bake.Tests/UnitTests/Services/PlatformParserTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public class PlatformParserTests : TestFor<PlatformParser>
{
[TestCase("win/x86", ExecutableOperatingSystem.Windows, ExecutableArchitecture.Intel32)]
[TestCase("linux/x64", ExecutableOperatingSystem.Linux, ExecutableArchitecture.Intel64)]
[TestCase("mac/arm64", ExecutableOperatingSystem.MacOSX, ExecutableArchitecture.Arm64)]
[TestCase("macos/arm64", ExecutableOperatingSystem.MacOSX, ExecutableArchitecture.Arm64)]
public void Success(
string str,
ExecutableOperatingSystem executableOs,
Expand Down
1 change: 1 addition & 0 deletions Source/Bake/Cooking/Cooks/GitHub/GitHubReleaseCook.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public class GitHubReleaseCook : Cook<GitHubReleaseRecipe>
{
[ExecutableArchitecture.Intel32] = "x86",
[ExecutableArchitecture.Intel64] = "x86_64",
[ExecutableArchitecture.Arm64] = "arm64",
};

private readonly ILogger<GitHubReleaseCook> _logger;
Expand Down
4 changes: 2 additions & 2 deletions Source/Bake/ValueObjects/Platform.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ namespace Bake.ValueObjects
{
public class Platform
{
public static Platform[] Defaults { get; } =
public static Platform[] Defaults { get; } =
{
new(ExecutableOperatingSystem.Windows, ExecutableArchitecture.Intel64),
new(ExecutableOperatingSystem.Linux, ExecutableArchitecture.Intel64),
new(ExecutableOperatingSystem.MacOSX, ExecutableArchitecture.Intel64),
new(ExecutableOperatingSystem.MacOSX, ExecutableArchitecture.Arm64),
};
public static Platform Any { get; } = new(ExecutableOperatingSystem.Any, ExecutableArchitecture.Any);

Expand Down
2 changes: 1 addition & 1 deletion TestProjects/NetCore.Console/NetCore.Console.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<PackageId>awesome-cli-tool</PackageId>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<IsTool>true</IsTool>
<PackAsTool>true</PackAsTool>
<ToolCommandName>magic-command</ToolCommandName>
Expand Down
Loading