utils: Preserve API by overloading libpisp::compute_optimal_stride #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature for compute_optimal_stride has changed, and it is called by libcamera extrenally. While adding a default parameter makes it backwards compatible, using libcamera.so to build rpicam-apps with -Wl, --no-undefined will cause undefined symbols. This change preserves the API by overloading the function to have both the previous and new signature. This will emit both symbols in the shared object. Only compute_optimal_stride in utils.hpp needs this change as this is the only function being used in libcamera as an API from utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature for
libpisp::compute_optimal_stridehas changed, and it is called by libcamera extrenally. While adding a default parameter makes it backwards compatible, using libcamera.so to build rpicam-apps with-Wl, --no-undefinedwill cause undefined symbols.This change preserves the API by overloading the function to have both the previous and new signature. This will emit both symbols in the shared object. Only
compute_optimal_strideinutils.hppneeds this change as this is the only function being used in libcamera as an API from utils.More context at https://bugs.launchpad.net/ubuntu/+source/libpisp/+bug/2115319