Failed to build due to README file.

[adminy]

Describe the bug

Trying to compile the latest 6.10.y kernel gives:

make[3]: *** No rule to make target 
   'arch/arm64/boot/dts/overlays/README', needed by 
   'arch/arm64/boot/dts/overlays/dtbs-list'.  Stop.
make[3]: *** Waiting for unfinished jobs....
make[1]: *** [/tmp/nix-build-linux-rpi-6.10.0-rc5.drv-0/source/Makefile:1405: dtbs] Error 2
make: *** [../Makefile:240: __sub-make] Error 2

Steps to reproduce the behaviour

I'm just trying to normally compile the kernel. no special steps.

linux/arch/arm/boot/dts/overlays/Makefile

Line 3 in f61d3ac

dtb-$(CONFIG_ARCH_BCM2835) += overlay_map.dtb hat_map.dtb README

I suspect its this piece of code has the README target, causing this to be treated as a dtb downstream

Device (s)

Raspberry Pi 5

System

N/a

Logs

No response

Additional context

No response

[adminy]

#6241

[pelwell]

I'm just trying to normally compile the kernel. no special steps.

List them - my builds are working.

[adminy]

I'm using the nixpkgs buildLinux derivation with the following flags:

modDirVersion = "6.10.0-rc5";
version = "6.10.0-rc5";
pname = "linux-rpi";
src = rpi-linux-6_10_0-rc5-src;
defconfig = "bcm2712_defconfig";
structuredExtraConfig = with lib.kernel; {
  BACKLIGHT_CLASS_DEVICE = yes;
  KUNIT = no;
};
features.efiBootStub = false;
kernelPatches = [];

with a postconfigure like so:

postConfigure = ''
  sed -i $buildRoot/.config -e 's/^CONFIG_LOCALVERSION=.*/CONFIG_LOCALVERSION=""/'
  sed -i $buildRoot/include/config/auto.conf -e 's/^CONFIG_LOCALVERSION=.*/CONFIG_LOCALVERSION=""/'
'';

The flake builds fine for 6.6.y branch, if you look carefully, that branch does not have the README file.

[pelwell]

That's not a "normal" Linux build. I want a list of "make" commands that demonstrate the problem.

[adminy]

This in turn calls the make commands in:

https://github.com/NixOS/nixpkgs/blob/5f24895313965092dbd4a622b85d1986f01e2138/pkgs/os-specific/linux/kernel/generic.nix#L167-L189

Normal is relative. To me its more normal not to make assumptions about which environment your machine is using. Because that leads to "works on my machine" problems. This is why I use the normal nix way of building the kernel, so that other people can replicate it. Anyways it seems like #6241 does actually fix the problem. You're probably not building the dtbs with make.

[by]

Can you build https://github.com/torvalds/linux ? -- That's the linux source.

[adminy]

yeah, I can try. Probably won't have the defconfig file though.

[by]

Alternatively and/or additionally, you will likely need to create a manual config with your environment (i.e., https://github.com/NixOS/nixpkgs/blob/d77bda728d5041c1294a68fb25c79e2d161f62b9/pkgs/os-specific/linux/kernel/manual-config.nix); if this fails, you might want to move your issue to https://github.com/NixOS/nixpkgs, as https://github.com/raspberrypi/linux compiles well according to the official way @ https://www.raspberrypi.com/documentation/computers/linux_kernel.html#build-the-kernel

[pelwell]

To be clear: I'm not saying that there isn't a problem somewhere in the overlay build rules, but unless I can reproduce the failure I won't feel comfortable that I have understood the issue, and therefore that the fix is a good one.

[sanderhollaar]

#6681 - fix: remove README from Makefile

[sanderhollaar]

Fixed with f9d8731

(I do not have permissions to close with comment)

[adminy]

That's great but still an issue in 6.12.y and 6.13.y branches. I believe your changes only made it to 6.14.y

[sanderhollaar]

I can create additional pull requests for 6.12.y and 6.13.y if these kernel versions are still relevant.