V4L2 codec updates#4002
Merged
popcornmix merged 2 commits intoraspberrypi:rpi-5.10.yfrom Dec 18, 2020
Merged
Conversation
Control V4L2_CID_MPEG_VIDEO_HEADER_MODE controls whether the encoder is meant to emit the header bytes as a separate packet or with the first encoded frame. Add support for it. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
It appears that the V4L2 M2M framework requires the driver to manually call vb2_clear_last_buffer_dequeued on the CAPTURE queue during a V4L2_DEC_CMD_START. Add such a call. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Contributor
Author
|
@popcornmix I'm assuming you're wanting to merge this to fix up seeking. |
Collaborator
|
Yes, been running with it for a few days. |
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Dec 18, 2020
kernel: V4L2 codec updates See: raspberrypi/linux#4002 kernel: drm/vc4: Make normalize_zpos conditional on using fkms See: raspberrypi/linux#4005 kernel: Revert media: videobuf2: Fix length check for single plane dmabuf queueing See: raspberrypi/linux#4004 kernel: KMS 10 & 12 bpc updates (5.10) See: raspberrypi/linux#3982
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 18, 2020
kernel: V4L2 codec updates See: raspberrypi/linux#4002 kernel: drm/vc4: Make normalize_zpos conditional on using fkms See: raspberrypi/linux#4005 kernel: Revert media: videobuf2: Fix length check for single plane dmabuf queueing See: raspberrypi/linux#4004 kernel: KMS 10 & 12 bpc updates (5.10) See: raspberrypi/linux#3982
popcornmix
referenced
this pull request
in popcornmix/xbmc
Dec 22, 2020
mkreisl
added a commit
to xbianonpi/xbian-sources-kernel
that referenced
this pull request
Dec 30, 2020
mkreisl
added a commit
to xbianonpi/xbian-sources-kernel
that referenced
this pull request
Feb 4, 2021
mkreisl
added a commit
to xbianonpi/xbian-sources-kernel
that referenced
this pull request
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst decode the edict is that the H264 header bytes should be with the first frame, encode appears to have a control that switches between that and putting them in a separate packet. FFmpeg chooses the latter.
Unobviously, the driver for decode has to manually kick the framework on DEC_CMD_START to clear the EOS flag. Add it.