drm/vc4: hdmi: Fix clock value used for validating hdmi modes#4826
Merged
pelwell merged 1 commit intoraspberrypi:rpi-5.10.yfrom Jan 13, 2022
Merged
drm/vc4: hdmi: Fix clock value used for validating hdmi modes#4826pelwell merged 1 commit intoraspberrypi:rpi-5.10.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-5.10.yfrom
Conversation
We are using mode->crt_clock here which is filled by drm_mode_set_crtcinfo() which is called right after .mode_valid. Use mode->clock which is valid here. Fixes: 624d93a ("drm/vc4: hdmi: Move clock calculation into its own function") Signed-off-by: Dom Cobley <popcornmix@gmail.com>
Collaborator
Author
|
This is similar to bug reported here: #4754 (review) @mripard can you check this. This is the cause of the regression in bullseye with latest kernel where 2560x1440 gives "flip done timed out". |
Contributor
|
Yep, it looks good to me |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 13, 2022
kernel: arm: Fix custom rpi __memset32 and __memset64 See: raspberrypi/linux#4820 kernel: drm/vc4: Disable Gamma control on HVS5 due to issues writing the table See: raspberrypi/linux#4825 kernel: drm/vc4: hdmi: Fix clock value used for validating hdmi modes See: raspberrypi/linux#4826 kernel: overlays: Add vl805 overlay See: https://forums.raspberrypi.com/viewtopic.php?t=326088 kernel: configs: add CONFIG_LEDS_TRIGGER_PATTERN=m See: raspberrypi/linux#4789 kernel: Add overlay for Azoteq IQS550 See: raspberrypi/linux#4813 kernel: dtoverlays: Add backlight-gpio parameter to vc4-kms-dpi-generic See: raspberrypi/linux#4815 kernel: bcm2835-v4l2-isp: Add missing lock initialization See: raspberrypi/linux#4800 kernel: media: i2c: ov9281: Increase diff between VTS and max exposure See: raspberrypi/linux#4807
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 13, 2022
kernel: arm: Fix custom rpi __memset32 and __memset64 See: raspberrypi/linux#4820 kernel: drm/vc4: Disable Gamma control on HVS5 due to issues writing the table See: raspberrypi/linux#4825 kernel: drm/vc4: hdmi: Fix clock value used for validating hdmi modes See: raspberrypi/linux#4826 kernel: overlays: Add vl805 overlay See: https://forums.raspberrypi.com/viewtopic.php?t=326088 kernel: configs: add CONFIG_LEDS_TRIGGER_PATTERN=m See: raspberrypi/linux#4789 kernel: Add overlay for Azoteq IQS550 See: raspberrypi/linux#4813 kernel: dtoverlays: Add backlight-gpio parameter to vc4-kms-dpi-generic See: raspberrypi/linux#4815 kernel: bcm2835-v4l2-isp: Add missing lock initialization See: raspberrypi/linux#4800 kernel: media: i2c: ov9281: Increase diff between VTS and max exposure See: raspberrypi/linux#4807
This was referenced Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using mode->crt_clock here which is filled by drm_mode_set_crtcinfo()
which is called right after .mode_valid.
Use mode->clock which is valid here.
Fixes: 624d93a ("drm/vc4: hdmi: Move clock calculation into its own function")
Signed-off-by: Dom Cobley popcornmix@gmail.com