ASoC: dwc: Correct channel count reporting #6023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DWC I2S driver treats the channel count register values as if they encode a power of two (2, 4, 8, 16), but they actually encode a multiple of 2 (2, 4, 6, 8). Also improve the error message when asked for an unsupported number of channels. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
approved these changes
Mar 11, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 12, 2024
See: raspberrypi/linux#6028 kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus See: raspberrypi/linux#6024 kernel: Imx296 updates See: raspberrypi/linux#6027 kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error See: raspberrypi/linux#6017 kernel: ASoC: dwc: Correct channel count reporting See: raspberrypi/linux#6023 kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels See: raspberrypi/linux#6005 kernel: Panel updates See: raspberrypi/linux#6019 kernel: Backport pwm-ir-tx precision improvements See: raspberrypi/linux#6018
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Mar 12, 2024
See: raspberrypi/linux#6028 kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus See: raspberrypi/linux#6024 kernel: Imx296 updates See: raspberrypi/linux#6027 kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error See: raspberrypi/linux#6017 kernel: ASoC: dwc: Correct channel count reporting See: raspberrypi/linux#6023 kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels See: raspberrypi/linux#6005 kernel: Panel updates See: raspberrypi/linux#6019 kernel: Backport pwm-ir-tx precision improvements See: raspberrypi/linux#6018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DWC I2S driver treats the channel count register values as if they encode a power of two (2, 4, 8, 16), but they actually encode a multiple of 2 (2, 4, 6, 8).
Also improve the error message when asked for an unsupported number of channels.