drm/vc4: plane: Swap Cb/Cr offsets for YVU formats #7124
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to "drm/vc4: plane: Swap Cb/Cr pointers for YVU formats" Swap the offsets as well as the buffer objects for YVU formats. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Contributor
Author
|
Rightly or wrongly, https://github.com/raspberrypi/linux/blob/rpi-6.12.y/drivers/gpu/drm/vc4/vc4_plane.c#L2571 only lets ptr0_offset[0] change with an async update. ptr0_offset[1] and ptr0_offset[2] can't change. I think that means that we can't (currently) update the chroma planes of a YUV/YVU frame with an async update, so there's no issue. When someone complains about async YUV updates I'll take another look. Dropping the draft status. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 4, 2025
kernel: drm/vc4: plane: Swap Cb/Cr pointers for YVU formats See: raspberrypi/linux#7122 kernel: drm/vc4: plane: Swap Cb/Cr offsets for YVU formats See: raspberrypi/linux#7124 kernel: media: imx477: Increase IMX477_VBLANK_MIN due to image corruption See: raspberrypi/linux#7114 kernel: staging: vc04_services: vc-sm-cma: Fix smatch warnings See: raspberrypi/linux#7116
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 4, 2025
kernel: drm/vc4: plane: Swap Cb/Cr pointers for YVU formats See: raspberrypi/linux#7122 kernel: drm/vc4: plane: Swap Cb/Cr offsets for YVU formats See: raspberrypi/linux#7124 kernel: media: imx477: Increase IMX477_VBLANK_MIN due to image corruption See: raspberrypi/linux#7114 kernel: staging: vc04_services: vc-sm-cma: Fix smatch warnings See: raspberrypi/linux#7116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to "drm/vc4: plane: Swap Cb/Cr pointers for YVU formats" Swap the offsets as well as the buffer objects for YVU formats.
Draft as I want to double check the async update path too.