drm/v3d: Add module parameter to enable MMU error logging #7193
Conversation
|
I'm happy with a module parameter to enable the error logging, but not at the expense of losing even the first error if the parameter is disabled. I would lose the reversion, and make the logging condition |
mairacanal
force-pushed
the
v3d/downstream/mmu-debug
branch
from
e7e7b98 to
338154d
Compare
I updated the branch with your suggestion. Thanks! |
|
Hey, gentle ping. It would be great to have this patch in the RPi kernel release to help debugging issues in Mesa CI. |
|
It looks OK now apart from the initialisation to false, which checkpatch complains about. With that fixed, I would be happy to merge. Any other concerns? |
MMU error messages are useful to help developers quickly identify issues in userspace graphics drivers, but always printing them can swamp the kernel log. Add a module parameter, ``debug_mmu``, to gate MMU error logging. Logging is disabled by default and can be enabled when needed with ``v3d.debug_mmu=1``. Signed-off-by: Maíra Canal <mairacanal@riseup.net>
mairacanal
force-pushed
the
v3d/downstream/mmu-debug
branch
from
338154d to
35f27c3
Compare
I just fixed the checkpatch issues. Thanks a lot! |
kernel: drm/v3d: Add module parameter to enable MMU error logging See: raspberrypi/linux#7193
kernel: drm/v3d: Add module parameter to enable MMU error logging See: raspberrypi/linux#7193
2 participants
Currently, downstream carries a commit that suppresses all but the first MMU error. While this avoids excessive logging, MMU error messages are often valuable for developers during debugging. At the moment, getting this information requires rebuilding the kernel with that commit reverted.
This PR proposes adding a new module parameter (downstream-only) to allow MMU error logging to be enabled on demand, avoiding the need to recompile the kernel.
As an alternative, we could simply revert the commit “drm/v3d: Suppress all but the first MMU error”, since MMU errors are no longer as frequent as they once were.
I'd appreciate to hear your thoughts about the preferred approach.