Skip to content

media: i2c: imx500: keep chip active while network firmware is loaded #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naushir merged 2 commits into from
Apr 21, 2026
+40 −2
Merged

media: i2c: imx500: keep chip active while network firmware is loaded #7323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11fcd75
media: i2c: imx500: Keep the device active while network firmware is …
naushir Apr 20, 2026
0ea340d
media: i2c: imx500: release rpk on subdev close
naushir Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions drivers/media/i2c/imx500.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
#include <media/v4l2-event.h>
#include <media/v4l2-fh.h>
#include <media/v4l2-fwnode.h>
#include <media/v4l2-mediabus.h>

Expand Down Expand Up @@ -1924,9 +1925,17 @@ static int imx500_clear_weights(struct imx500 *imx500)

static void imx500_clear_fw_network(struct imx500 *imx500)
{
struct i2c_client *client = v4l2_get_subdevdata(&imx500->sd);

/* Remove any previous firmware blob. */
if (imx500->fw_network)
if (imx500->fw_network) {
vfree(imx500->fw_network);
/*
* Release the PM ref taken when the fw was loaded in
* imx500_set_ctrl().
*/
pm_runtime_put_noidle(&client->dev);
}

imx500->fw_network = NULL;
imx500->network_written = false;
Expand Down Expand Up @@ -2138,6 +2147,13 @@ static int imx500_set_ctrl(struct v4l2_ctrl *ctrl)
}

imx500_clear_fw_network(imx500);

/*
* Take a pm_runtime reference before the read. This keeps
* the device active as long as a NW firmware has been loaded.
*/
pm_runtime_resume_and_get(&client->dev);

ret = kernel_read_file_from_fd(ctrl->val, 0,
(void **)&imx500->fw_network, INT_MAX,
&imx500->fw_network_size,
Expand All @@ -2151,7 +2167,8 @@ static int imx500_set_ctrl(struct v4l2_ctrl *ctrl)
if (ret < 0) {
dev_err(&client->dev, "%s failed to read fw image: %d\n",
__func__, ret);
imx500_clear_fw_network(imx500);
/* Release the ref we took above. */
pm_runtime_put_noidle(&client->dev);
return ret;
}
if (ret != imx500->fw_network_size) {
Expand Down Expand Up @@ -2315,6 +2332,26 @@ static const struct v4l2_ctrl_ops imx500_ctrl_ops = {
.s_ctrl = imx500_set_ctrl,
};

static int imx500_subdev_close(struct v4l2_subdev *sd,
struct v4l2_subdev_fh *fh)
{
struct imx500 *imx500 = to_imx500(sd);
/*
* Release the cached rpk when the last userspace handle on the subdev
* is closed. This also drops the pm_runtime reference ta taken in the
* NETWORK_FW_FD branch of imx500_set_ctrl(), so the device can
* autosuspend between sessions.
*/
if (v4l2_fh_is_singular(&fh->vfh))
imx500_clear_fw_network(imx500);

return 0;
}

static const struct v4l2_subdev_internal_ops imx500_internal_ops = {
.close = imx500_subdev_close,
};

static const struct v4l2_ctrl_config imx500_notify_gains_ctrl = {
.ops = &imx500_ctrl_ops,
.id = V4L2_CID_NOTIFY_GAINS,
Expand Down Expand Up @@ -3616,6 +3653,7 @@ static int imx500_probe(struct i2c_client *client)
goto error_power_off;

/* Initialize subdev */
imx500->sd.internal_ops = &imx500_internal_ops;
imx500->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
V4L2_SUBDEV_FL_HAS_EVENTS;
imx500->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
Expand Down
Loading