media: imx708: Support configuring continuous clock from DT#7329
Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom Apr 27, 2026
Merged
media: imx708: Support configuring continuous clock from DT#7329pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
Conversation
The driver was always using non-continuous clock mode. Add support for selecting continuous clock mode as well. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Contributor
Author
|
Confirmed to work. @naushir for review |
Contributor
|
LGTM |
Contributor
|
It all looks plausible, apart from the name. Are you adding continuous or non-continuous clock support? |
Contributor
|
To clarify, I see the comment that the patch adds continuous support, but the sense of the flag appears to be the other way round - either non-continuous or 0. How does this work? |
Contributor
Author
|
Register 0x3220 defaults to 0x01 for non-continuous clock. Our dtoverlays also set that flag but the driver used to ignore it. This patch adds checking the flag from DT and setting 0x3220 to 0x00 if not set, or keeps it at 0x01 if it is set. |
Contributor
|
That makes (opposite) sense. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 1, 2026
kernel: staging: vc04_services: vchiq-mmal: validate component index in event_to_host_cb() See: raspberrypi/linux#7327 kernel: tdo_panel: bcm27xx-gpu: Add dsi panel driver See: raspberrypi/linux#7318 kernel: Change crop struct to match height for 16 by 9 mode See: raspberrypi/linux#7328 kernel: media: imx708: Support configuring continuous clock from DT See: raspberrypi/linux#7329 kernel: Display driver fixups See: raspberrypi/linux#7332 kernel: fixup! gpiolib: Override gpiochip numbers with DT aliases See: raspberrypi/linux#7341
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 1, 2026
kernel: staging: vc04_services: vchiq-mmal: validate component index in event_to_host_cb() See: raspberrypi/linux#7327 kernel: tdo_panel: bcm27xx-gpu: Add dsi panel driver See: raspberrypi/linux#7318 kernel: Change crop struct to match height for 16 by 9 mode See: raspberrypi/linux#7328 kernel: media: imx708: Support configuring continuous clock from DT See: raspberrypi/linux#7329 kernel: Display driver fixups See: raspberrypi/linux#7332 kernel: fixup! gpiolib: Override gpiochip numbers with DT aliases See: raspberrypi/linux#7341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver was always using non-continuous clock mode. Add support for selecting continuous clock mode as well.
Draft pull request whilst I check with the requester that it does what is needed.