Partially revert "ata: ahci: force 32-bit DMA for JMicron JMB582/JMB585"#7393
Merged
Conversation
Collaborator
|
What do you think about making this a partial revert just to minimise future conflicts? |
Contributor
Author
|
A minimal patch would be something like this: [board_ahci_jmb585] = {
AHCI_HFLAGS (AHCI_HFLAG_IGN_IRQ_IF_ERR |
- AHCI_HFLAG_32BIT_ONLY),
+ 0*AHCI_HFLAG_32BIT_ONLY),
.flags = AHCI_FLAG_COMMON, |
pelwell
changed the title
Contributor
Author
|
Resubmitted as a minimal partial reversion. |
popcornmix
approved these changes
May 22, 2026
Contributor
Author
|
Are you OK with this, @P33M? |
P33M
approved these changes
May 22, 2026
This partially reverts commit 105c425. Between [1] and this partial reversion, all users of the JMB582/JMB585 on Raspberry Pi 5 have been forced to use the pcie-32bit-dma overlay. The reasoning behind the patch is either inherently flawed or does not apply on a Pi 5, since all inbound memory accesses are by default above 4GB and yet seem to work. See: raspberrypi#7355 https://forums.raspberrypi.com/viewtopic.php?p=2374573&sid=a9d90a55d42694d4f24bf03946e44a4f#p2374573 Signed-off-by: Phil Elwell <phil@raspberrypi.com> [1] commit 105c425 ("ata: ahci: force 32-bit DMA for JMicron JMB582/JMB585")
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 22, 2026
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 105c425.
Between [1] and this reversion of it, all users of the JMB582/JMB585 on Raspberry Pi 5 have been forced to use the pcie-32bit-dma overlay.
The reasoning behind the patch is either inherently flawed or does not apply on a Pi 5, since all inbound memory accesses are by default above 4GB and yet seem to work.
See: #7355
https://forums.raspberrypi.com/viewtopic.php?p=2374573&sid=a9d90a55d42694d4f24bf03946e44a4f#p2374573
Signed-off-by: Phil Elwell phil@raspberrypi.com
[1] commit 105c425 ("ata: ahci: force 32-bit DMA for JMicron JMB582/JMB585")