net: bcmgenet: restore PHY power management flags#7403
Open
nbuchwitz wants to merge 1 commit into
Open
Conversation
Restore PHY_BRCM_AUTO_PWRDWN_ENABLE, PHY_BRCM_DIS_TXCRXC_NOENRGY and PHY_BRCM_IDDQ_SUSPEND in bcmgenet_mii_probe(), reverting the downstream hunk that snuck into 7dd290a ("xhci: add quirk...") back in March 2022. That hunk worked around raspberrypi/rpi-eeprom#417: on Pi 4B rev 1.1 only, the bootloader couldn't recover the PHY from IDDQ-SR after a kernel reboot. CM4 and newer Pi 4B revs were never affected. The rpi-eeprom fix shipped in April 2022 (release c68f0c06) and the issue was closed a month later. With the bootloader fix ~4 years deployed, drop the kernel-side workaround and get back the "several hundreds of milliwatts" of idle power savings Florian quoted in the issue thread. Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Contributor
Author
|
Needs testing on Pi 4B rev 1.1 (I only have one 1.2 at hand) + network booting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore PHY_BRCM_AUTO_PWRDWN_ENABLE, PHY_BRCM_DIS_TXCRXC_NOENRGY and PHY_BRCM_IDDQ_SUSPEND in bcmgenet_mii_probe(), reverting the downstream hunk that snuck into 7dd290a ("xhci: add quirk...") back in March 2022.
That hunk worked around raspberrypi/rpi-eeprom#417: on Pi 4B rev 1.1 only, the bootloader couldn't recover the PHY from IDDQ-SR after a kernel reboot. CM4 and newer Pi 4B revs were never affected. The rpi-eeprom fix shipped in April 2022 (release c68f0c06) and the issue was closed a month later.
With the bootloader fix ~4 years deployed, drop the kernel-side workaround and get back the "several hundreds of milliwatts" of idle power savings Florian quoted in the issue thread.