NOOBS 1.3 failed to compile at recovery 1.0 : qjson/parser.h: No such file or directory

[mhtrinh]

My system :
OpenSuse 12.3
Linux mhtrinh 3.7.10-1.24-desktop #1 SMP PREEMPT Wed Oct 2 11:15:18 UTC 2013 (375b8b4) x86_64 x86_64 x86_64 GNU/Linux
CPU: i7-2600
BUILDME.sh failed when building recovery :

>>> recovery 1.0 Building
(cd /home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/build/recovery-1.0 ; /home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/host/usr/bin/qmake -spec qws/linux-arm-g++)
Updating 'translation_nl.ts'...
    Found 126 source text(s) (0 new and 126 already existing)
Updating 'translation_de.ts'...
    Found 126 source text(s) (0 new and 126 already existing)
Updating 'translation_pt.ts'...
[...]
/home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-g++ -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os -O2 -Wall -W -D_REENTRANT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/mkspecs/qws/linux-arm-g++ -I. -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtCore -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtNetwork -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtGui -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I. -I. -o moc_mainwindow.o moc_mainwindow.cpp
/home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabi-g++ -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -pipe -Os -O2 -Wall -W -D_REENTRANT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/mkspecs/qws/linux-arm-g++ -I. -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtCore -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtNetwork -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/QtGui -I../../host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I. -I. -o moc_languagedialog.o moc_languagedialog.cpp
json.cpp:2:26: fatal error: qjson/parser.h: No such file or directory
compilation terminated.
make[1]: *** [json.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from mainwindow.cpp:1:0:
mainwindow.h: In constructor 'MainWindow::MainWindow(const QString&, QSplashScreen*, QWidget*)':
mainwindow.h:45:20: warning: 'MainWindow::_splash' will be initialized after [-Wreorder]
mainwindow.h:42:10: warning:   'bool MainWindow::_silent' [-Wreorder]
mainwindow.cpp:59:1: warning:   when initialized here [-Wreorder]
make[1]: Leaving directory `/home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/build/recovery-1.0'
make: *** [/home/mhtrinh/travail/BBCTech/RPi/noobs/noobs_git/buildroot/output/build/recovery-1.0/.stamp_built] Error 2

Is some kind of wrong order when building packages ? Like qjson should be build before recovery ??
Because i do have qjson/parser.h in /usr/include, but not in buildroot

[lurch]

Sorry you're having so many problems getting NOOBS compiled :(

From a quick look at my own NOOBS build tree, I have qjson/parser.h in buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/qjson/parser.h

What does your buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/ show?

[mhtrinh]

I don't have it in my buildroot :

find ./buildroot/ -iname "parser.h"  
./buildroot/output/build/qt-4.8.5/tools/porting/src/parser.h
./buildroot/output/build/qt-4.8.5/src/tools/moc/parser.h
./buildroot/output/build/qt-4.8.5/src/tools/uic3/parser.h
./buildroot/output/build/qt-4.8.5/src/3rdparty/javascriptcore/JavaScriptCore/parser/Parser.h
./buildroot/output/build/qt-4.8.5/src/3rdparty/webkit/Source/ThirdParty/ANGLE/src/compiler/preprocessor/parser.h
./buildroot/output/build/qt-4.8.5/src/3rdparty/webkit/Source/JavaScriptCore/parser/Parser.h
./buildroot/output/toolchain/gcc-4.7.3/libjava/javax/swing/text/html/parser/Parser.h
./buildroot/output/toolchain/gcc-4.7.3/libjava/org/xml/sax/Parser.h
./buildroot/output/toolchain/gcc-4.7.3/libjava/gnu/javax/swing/text/html/parser/support/Parser.h
./buildroot/output/toolchain/gcc-4.7.3/gcc/cp/parser.h
./buildroot/output/toolchain/linux-3.9/include/linux/parser.h

My buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/ http://pastebin.com/raw.php?i=UedU5B8h

Here is my buildroot/output/build/

ls -lrt buildroot/output/build/
total 92
drwxr-xr-x  4 mhtrinh users  4096 Jan 14 10:49 buildroot-config
drwxr-xr-x 10 mhtrinh users  4096 Jan 14 10:49 host-m4-1.4.16
drwxr-xr-x 16 mhtrinh users  4096 Jan 14 10:50 host-gmp-5.1.1
drwxr-xr-x  9 mhtrinh users  4096 Jan 14 10:50 host-mpfr-3.1.2
drwxr-xr-x  5 mhtrinh users  4096 Jan 14 10:50 host-libtool-2.2.10
drwxr-xr-x  9 mhtrinh users  4096 Jan 14 10:50 host-autoconf-2.68
drwxr-xr-x  7 mhtrinh users  4096 Jan 14 10:50 host-automake-1.11.6
drwxr-xr-x  7 mhtrinh users  4096 Jan 14 10:51 host-mpc-1.0.1
drwxr-xr-x 18 mhtrinh users  4096 Jan 14 10:51 host-binutils-2.21.1
drwxr-xr-x 18 mhtrinh users  4096 Jan 14 11:02 host-ncurses-5.9
drwxr-xr-x 17 mhtrinh users  4096 Jan 14 11:02 ncurses-5.9
drwxr-xr-x  6 mhtrinh users  4096 Jan 14 11:02 readline-6.2
drwxr-xr-x 18 mhtrinh users  4096 Jan 14 11:03 lvm2-2.02.79
drwxr-xr-x 22 mhtrinh users  4096 Jan 14 11:03 libiconv-1.14
drwxr-xr-x  5 mhtrinh users 12288 Jan 14 11:03 mtools-4.0.18
drwxr-xr-x  4 mhtrinh users  4096 Jan 14 11:03 host-pkgconf-0.8.9
drwxr-xr-x 14 mhtrinh users  4096 Jan 14 11:03 zlib-1.2.7
drwxr-xr-x 21 mhtrinh users  4096 Jan 14 11:16 qt-4.8.5
drwxr-xr-x  8 mhtrinh users  4096 Jan 14 11:16 arora-master
drwxr-xr-x  6 mhtrinh users  4096 Jan 14 11:16 dosfstools-3.0.16
drwxr-xr-x  3 mhtrinh users  4096 Jan 14 11:16 recovery-1.0

I suppose that somehow on my machine, recovery is built before qjson package. Where do you order what package should be build first ??

[maxnet]

Where do you order what package should be build first ??

Add qjson here: https://github.com/raspberrypi/noobs/blob/master/buildroot/package/recovery/recovery.mk#L14

And should also add "select BR2_PACKAGE_QJSON" here: https://github.com/raspberrypi/noobs/blob/master/buildroot/package/recovery/Config.in#L4
The last is not necessary for build, but that the menuconfig shows correctly that qjson is a requirement and cannot be unchecked.
Can also remove libcurl there while you are at it. It is no longer used.

[lurch]

Thanks once again for your buildroot-help @maxnet, much appreciated - I'll tackle fixing this particular bug tomorrow :-)

Is there any relationship between the 'dependency-lists' in recovery/recovery.mk and recovery/Config.in ?
I can see how Config.in is only used for modifying the selections in buildroot's .config and recovery.mk is (presumably) what's used to ensure the buildroot packages get built in the correct order, but I'm wondering if there's any formal relationship between the two, or whether they're just two separate places in which the dependencies need to be separately kept in sync?

Is this similar to #169 in that it only hasn't bit us in the ass before because we've been lucky in what order the filesystem returns directory-listings in?
I guess there's probably quite a few different packages that ought be listed as dependencies of the core 'recovery' package...

[maxnet]

Is there any relationship between the 'dependency-lists' in recovery/recovery.mk and recovery/Config.in ?

They really are supposed to match, and be kept in sync.

However in practice the behavior is that if a package is listed as dependency in the .mk it will always get build, regardless if the dependency is listed in Config.in and also regardless if the dependency was selected and is in .config
(as long as the dependent package is in .config)

Is this similar to #169 in that it only hasn't bit us in the ass before because we've been lucky in what order the filesystem returns directory-listings in?

Not sure.
Could also be something else, like that the user has different locale settings than us.
Believe one of those environment settings can also affect various sort operations (LC_COLLATE?)

But that is just guessing. No matter what causes the different behavior, fact remains it is not always reproducible, which makes bugs like this easy to overlook.

[mhtrinh]

Thanks guys !! With that qjson dependencies patch, I manage to build my NOOBS ! YeY
Here is my git diff :

diff --git a/buildroot/package/recovery/Config.in b/buildroot/package/recovery/Config.in
index 476f10c..b00e439 100644
--- a/buildroot/package/recovery/Config.in
+++ b/buildroot/package/recovery/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_RECOVERY
         bool "recovery"
     select BR2_PACKAGE_QT
-    select BR2_PACKAGE_LIBCURL
+    select BR2_PACKAGE_QJSON
         help
           recovery GUI 

diff --git a/buildroot/package/recovery/recovery.mk b/buildroot/package/recovery/recovery.mk
index a721d93..57586a2 100644
--- a/buildroot/package/recovery/recovery.mk
+++ b/buildroot/package/recovery/recovery.mk
@@ -11,7 +11,7 @@ RECOVERY_SITE_METHOD=local
 RECOVERY_LICENSE = BSD-3c
 RECOVERY_LICENSE_FILES = LICENSE.txt
 RECOVERY_INSTALL_STAGING = NO
-RECOVERY_DEPENDENCIES=qt
+RECOVERY_DEPENDENCIES=qt qjson

 define RECOVERY_BUILD_CMDS
        (cd $(@D) ; $(QT_QMAKE))

[ntolva]

I also required this patch. Please merge it, unless there's some horrible consequence.

[lurch]

Apologies, the reason I hadn't merged this patch yet was that I was intending to go through thoroughly and check that all the package dependencies for the 'recovery' package were set up correctly (to prevent this error popping up for different packages in the future). But I've obviously not got round to that yet, so for now please just manually apply @mhtrinh 's patch.

[DANSI]

I have also had to use this patch - using Ubuntu 14.04.
wget1.14 also have to be updated, because it won't compile.
details: http://lists.gnu.org/archive/html/bug-wget/2013-05/msg00105.html
i used wget1.16 in my compile. (changed https://github.com/raspberrypi/noobs/blob/master/buildroot/package/wget/wget.mk#L7
to 1.16)

bye DANSI