This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Fix generation of the rpi-firmware and rpi-userland version files #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They weren't being updated correctly, and they shouldn't have been stored in git in the first place
Rob-Bishop
pushed a commit
that referenced
this pull request
Jun 22, 2013
Fix generation of the rpi-firmware and rpi-userland version files
|
@lurch: Thanks for this - my original fix to include this data was very quick and hacky so I appreciate the effort to clean it up. Do we also need to add the .version files to the .gitignore to prevent them being accidentally added to the repo (as happened in the previous case)? |
|
I already thought of that ;-) That's why I moved them to the buildroot/dl/ directory, which is already included in the .gitignore file (and IMHO having the .version files right next to the .tar.gz files also makes logical sense). |
|
Thanks @lurch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They weren't being updated correctly, and they shouldn't have been
stored in git in the first place