Skip to content

PIO Quadrature fixes #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilograham merged 2 commits into from
May 16, 2022
Merged

PIO Quadrature fixes #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb0dbc
Enable internal pullup on B-pin.
jvanderneutstulen Jan 18, 2022
3993415
pio_gpio_init is not needed for input pins.
jvanderneutstulen Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pio/quadrature_encoder/quadrature_encoder.pio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ increment_cont:
static inline void quadrature_encoder_program_init(PIO pio, uint sm, uint offset, uint pin, int max_step_rate)
{
pio_sm_set_consecutive_pindirs(pio, sm, pin, 2, false);
pio_gpio_init(pio, pin);
gpio_pull_up(pin);
gpio_pull_up(pin + 1);

pio_sm_config c = quadrature_encoder_program_get_default_config(offset);
sm_config_set_in_pins(&c, pin); // for WAIT, IN
Expand Down