Allow overriding of default config for pico_audio #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Rather than configuring explicit PIO and DMA numbers, I wonder if it might be better to update this to use the newer "claim" API functions, e.g. pio_claim_free_sm_and_add_program and dma_claim_unused_channel ? |
Contributor
Author
|
Agreed, but I don't think we should get rid of this function for libraries that depend on the older API. Those should be new functions. Or maybe we claim unused if you pass in NULL for the config? |
Contributor
|
The code in pico-extras is "experimental, use at your own risk", so I'm not sure if we need to worry about maintaining compatibility with an "older API" ? (but this is more of a @kilograham decision) |
kilograham
approved these changes
Apr 2, 2025
lurch
reviewed
Apr 2, 2025
ArkinSolomon
added a commit
to ArkinSolomon/pico-extras
that referenced
this pull request
Apr 2, 2025
This reverts commit 77c3d5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the pin could be overridden for pico_audio. This PR allows overriding other parts of the default configuration, so that the state machine # and DMA channels can be modified at compile time. It does not make sense for only one part of the default configuration to be overridden.