New icon component#103
Merged
designmatty merged 5 commits intomasterfrom Nov 15, 2018
Merged
Conversation
- handles svg -> theme conversion process - adds all default icons to the defaultTheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
Demo
Notes
There is some optimization to be done. The cli tool is a little fragile currently. The removal of direct theme editing isn't ideal. We're aware of the issues but will tackle them in future issues.
Testing Instructions
This has been tested by @alkamin and myself in a paired session.
Closes #21