Conversation
alkamin
approved these changes
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduce the Box component.
We considered two existing approaches to this component:
Kitchen Sink. eg, Pulse. Create an omnibus component that includes virtually every styled-system function.
Family of Layout Components. eg, Rebass. Create a set of layout components, one for each layout model.
Boxwould encapsulate styled-system's flow layout functions.Flexwould extendBox, setdisplay: flex, and add flex props.Gridwould do the same for grid layout.I opted to thread the needle with a hybrid approach. Our
Boxcomponent is single component that supports all 3 layouts (flow, flex, grid) but strictly limits itself to layout only (so strictly, in fact, that unlike Rebass it even excludesfontSizeandcolor).Included styled-system functions
margin & padding:
spacelayout:
display,verticalAlign, all flex props, all grid propsdimensions:
width,height,{min, max}{Width, Height},ratiocontainment:
overflowposition:
position,zIndex,top,right,bottom,leftExcluded styled-system functions
type:
fontFamily,textAlign,lineHeight,fontWeight,fontStyle,letterSpacing,textStylevisual:
background*,border*,boxShadow,opacity,colorStyleChecklist
Are there any of the following in this PR?
If one of the above is checked...
Upgrade InstructionsDemo
Closes #87