Normalize styled system and default props. Add Text component.#114
Merged
designmatty merged 21 commits intomasterfrom Dec 13, 2018
Merged
Conversation
Replace `entities` theme dictionary with `separator` and `separatorIcon` props. Resolves #113.
- Removed (labeled) ProgressBar, which needs more attention to work with styled-system, etc. It was rudimentary, so no real loss. - Renamed PlainProgressBar to ProgressBar.
alkamin
approved these changes
Dec 11, 2018
Contributor
alkamin
left a comment
There was a problem hiding this comment.
Things are getting exciting.
designmatty
approved these changes
Dec 13, 2018
Contributor
designmatty
left a comment
There was a problem hiding this comment.
I noticed borderColor wasn't working on NavBar. I pushed up a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update all existing components to use styled-system, to use
defaultPropsfor default props, and to extend theBoxcomponent when appropriate.Note
defaultPropsforspaceprops should be defined for each side individually (pt, pb, pl, pr,mt, mb, ml, mr). Don't use shortcuts (px, py, p,mx, my, m) even if the values are the same.Headersize is now handled via theasprop (eg,<Header as="h4">) instead of via utility properties on Header (eg,<Header.h4>) that used styled-component's now-likely-to-be-deprecatedwithComponent().Also some additions, deletions, renames:
Added a
Textcomponent. Renders as<p>, so should be no problem using theasprop. Closes New Component: Text #36.ProgressBardeleted (was rudimentary).PlainProgressBarrenamed toProgressBar.typeSystemdeleted from theme, now that all references have been changed to styled-system-friendlyfontSizesAlso misc fixes:
...foo.PropTypes->...foo.propTypes(case fix)${color};->${color})true/falsetoyes/noin docz props table Required cols, to distinguish from boolean props in adjacent Default colsBreaking changes: There are likely very many breaking changes throughout this PR. I can detail them individually if necessary, but it seems like that would be wasted work at this early stage when only an earlier version of it has been rudimentarily deployed.
Checklist
Are there any of the following in this PR?
If one of the above is checked...
Upgrade InstructionsDemo
Closes #36