Global styles and rename Link component#115
Merged
Conversation
Contributor
Author
|
Added ce37d9b to set up default fonts:
@designmatty Note that last bit, where I opted to set |
- Change theme `fonts` object to include `body`, `display`, `code` - Set `<body>` font-family to `fonts.body` in `GlobalStyle` - Default `<Header>` font-family to `fonts.display` via `defaultProps`
lederer
force-pushed
the
feature/sml/global-styles
branch
from
6a620ec to
ce37d9b
Compare
designmatty
approved these changes
Dec 18, 2018
Contributor
designmatty
left a comment
designmatty
left a comment
There was a problem hiding this comment.
Once CLI finishes @lederer this is good to go.
Contributor
Author
|
Awesome. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduce
GlobalStylecomponent to handle (opinionated) CSS reset.Deprecate
reset.css, including all references in build scripts and docs.Rename
Linkcomponent toAto avoid conflict with react-router.Drive-by tweak to
Headerto ensureasprop defaults toh1.Checklist
Are there any of the following in this PR?
If one of the above is checked...
Upgrade InstructionsNotes
I created
GlobalStyleusing the blaster CLI so it lives as just another component in the core package. I thought about whether it would make sense to put it somewhere else, since it's sort of a system-level component, not one to be generally used by consumers. But, I couldn't think of a better place to put it, and since it's technically a styled-component like any other, I figured this is good enough for now.I also considered what to name it, ultimately landing on GlobalStyle simply because that's what styled-components calls it. Should help minimize confusion.
A couple of enhancements we could make:
resetprop that defaults totrue, allowing consumers to opt out of the meyer reset code we're using.cssprop allowing consumers to pass in their own custom global CSS.I'd be happy to make those enhancements as part of this PR if it makes sense.
Closes #92
Closes #93