Skip to content

Implement icon index strategy#118

Merged
alkamin merged 3 commits intomasterfrom
feature/ak/icon-index
Jan 2, 2019
Merged

Implement icon index strategy#118
alkamin merged 3 commits intomasterfrom
feature/ak/icon-index

Conversation

@alkamin
Copy link
Copy Markdown
Contributor

@alkamin alkamin commented Dec 22, 2018

Overview

This PR streamlines the icon generation process and avoids having two copies of the theme around. Instead, this method generates an icon index file which gets imported into the default theme.

Checklist

  • [NA] Relevant documentation pages have been created or updated
  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • Check out the icons and see that they work as they did before

Closes #108

updates README /
remove theme var from CLI
@designmatty
Copy link
Copy Markdown
Contributor

designmatty commented Dec 27, 2018

I went in and made a few adjustments to this PR for general maintenance (see commit message). I'm going to ask that you review to double check things are still as intended. Everything worked as expected from my view point.

@alkamin alkamin merged commit da45f07 into master Jan 2, 2019
@alkamin alkamin deleted the feature/ak/icon-index branch January 2, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants