Skip to content

Fix filtering for files method#120

Merged
alkamin merged 3 commits intomasterfrom
feature/ak/fix-file-filtering
Jan 2, 2019
Merged

Fix filtering for files method#120
alkamin merged 3 commits intomasterfrom
feature/ak/fix-file-filtering

Conversation

@alkamin
Copy link
Copy Markdown
Contributor

@alkamin alkamin commented Jan 2, 2019

Overview

This PR adds extension filtering to the files method within the CLI and then uses that functionality to properly filter for .js files when generating the common index for each package.

Checklist

  • [NA] Relevant documentation pages have been created or updated
  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Testing Instructions

  • Pull down the branch
  • Delete the contents of the core package's index.common.js file
  • blaster i
  • Verify that the README.md file did not show up in the index.common.js file and that the other files were properly referenced

Closes #119

@alkamin alkamin requested a review from designmatty January 2, 2019 18:07
@alkamin alkamin changed the title Fix file filtering for files Fix filtering for files method Jan 2, 2019
Copy link
Copy Markdown
Contributor

@designmatty designmatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alkamin alkamin merged commit 5b71a48 into master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants