Skip to content

Table#132

Merged
lederer merged 2 commits intomasterfrom
feature/sml/table
Feb 19, 2019
Merged

Table#132
lederer merged 2 commits intomasterfrom
feature/sml/table

Conversation

@lederer
Copy link
Copy Markdown
Contributor

@lederer lederer commented Feb 12, 2019

Overview

Add a Table component.

Table is a simple component that merely renders an HTML <table> element but affords common customizations via props, eg, density, zebra striping (striped, stripeColor), hovered row highlighting (hoverable, hoverColor, hoverCursor), various border combinations (bordered, borderInside, borderOutside, borderRows, borderColumns, borderHeader, borderColor, borderWidth).

With the exception of borderHeader, the above props are generally turned off by default.

It expects standard HTML table children (<thead>, <tbody>, <tr>, <th>, <td>, etc).

It is agnostic to content and content styling, although it does set <th> font-weight to bold.

Checklist

  • Relevant documentation pages have been created or updated
  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible

Are there any of the following in this PR?

  • Changes to the prop names or types of existing components
  • Changes in intended behavior of existing component props
  • Changes in the theme file's structure
  • A required version bump to a non-dev dependency of the project

If one of the above is checked...

  • information or guidance around needed changes for consumers of this library has been added to the changelog under Upgrade Instructions

Demo

image

image

Closes #22

Copy link
Copy Markdown
Contributor

@designmatty designmatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's not forget to make this themable once we get that PR merged in

@lederer lederer merged commit ed9e3a0 into master Feb 19, 2019
@lederer lederer deleted the feature/sml/table branch February 19, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants