Conversation
07f7883 to
728d661
Compare
designmatty
approved these changes
Feb 19, 2019
Contributor
designmatty
left a comment
There was a problem hiding this comment.
Looks good. Let's not forget to make this themable once we get that PR merged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a Table component.
Table is a simple component that merely renders an HTML
<table>element but affords common customizations via props, eg, density, zebra striping (striped,stripeColor), hovered row highlighting (hoverable,hoverColor,hoverCursor), various border combinations (bordered,borderInside,borderOutside,borderRows,borderColumns,borderHeader,borderColor,borderWidth).With the exception of
borderHeader, the above props are generally turned off by default.It expects standard HTML table children (
<thead>,<tbody>,<tr>,<th>,<td>, etc).It is agnostic to content and content styling, although it does set
<th>font-weighttobold.Checklist
Are there any of the following in this PR?
If one of the above is checked...
Upgrade InstructionsDemo
Closes #22