Skip to content

Make Text element inherit font size#235

Merged
alkamin merged 2 commits intodevelopfrom
feature/ak/text-font-size
Dec 18, 2019
Merged

Make Text element inherit font size#235
alkamin merged 2 commits intodevelopfrom
feature/ak/text-font-size

Conversation

@alkamin
Copy link
Copy Markdown
Contributor

@alkamin alkamin commented Dec 18, 2019

Overview

This PR makes Text components inherit font-size which allows for more predictable usage. I think it makes sense since that is how spans work and since the GlobalStyle component makes the font size for body themeable.

Checklist

  • Relevant documentation pages have been created or updated
  • Description of PR is in an appropriate section of the changelog and grouped with similar changes if possible
  • [-] Relevant status has been updated on the status page

Testing Instructions

  • See new doc example in action

Closes #234

Copy link
Copy Markdown
Contributor

@designmatty designmatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

@lederer lederer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alkamin alkamin merged commit 2a83ac7 into develop Dec 18, 2019
@alkamin alkamin deleted the feature/ak/text-font-size branch December 18, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Nested Text components don't inherit styles as expected

3 participants