feat: Integrate Task Master AI and refine Cursor rules #44
Conversation
Adds configuration for the Task Master AI MCP server and refactors the Cursor
rules documentation to support a task-driven development workflow using
Task Master.
Changes include:
- Added `.cursor/mcp.json` to configure the `task-master-ai` MCP server
and include necessary API keys.
- Added Task Master configuration (`.taskmaster/config.json`) and an
example PRD template (`.taskmaster/templates/example_prd.txt`).
- Updated `.gitignore` to exclude Task Master generated files and logs.
- Refactored `.cursor/rules/` into more specific files:
- Renamed `coding-conventions.mdc` to `code-comments.mdc`.
- Created new rules for backend error handling, backend logging,
code style, general Cursor rule guidelines, development workflow
(focusing on Task Master), self-improvement/rule maintenance, and
a detailed Task Master tool/command reference.
- Modified existing general rules (`backend.mdc`, `frontend.mdc`,
`project-conventions.mdc`, `ui-ux-design-guidelines.mdc`) to remove
specific content (now in dedicated files) and adjusted their
`alwaysApply` flags to `false` as they are now high-level guides.
- The new `dev_workflow.mdc` and `taskmaster.mdc` rules provide detailed
guidance on using Task Master, including MCP/CLI interactions, task
management, dependencies, complexity analysis, and the iterative
subtask implementation process.
- `cursor_rules.mdc` provides guidelines for writing and maintaining
the rule files themselves.
- `self_improve.mdc` outlines triggers and processes for pattern
recognition and rule updates.
This update provides a more structured and documented approach to
development tasks and project conventions, tightly integrated with the
Task Master AI tool.
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces several new markdown documentation and configuration files, primarily for development workflow, code style, backend practices, and Taskmaster tool usage. It also restructures or removes metadata and rules in existing files, particularly splitting backend logging and error handling into dedicated documents and refining project conventions. The Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Taskmaster CLI/MCP
participant Config File
participant Rule Docs
Developer->>Taskmaster CLI/MCP: Initialize project / manage tasks
Taskmaster CLI/MCP->>Config File: Load AI model and global settings
Taskmaster CLI/MCP->>Rule Docs: Reference rules for code style, backend, workflow
Developer->>Rule Docs: Consult guidelines for error handling, logging, code style
Taskmaster CLI/MCP->>Developer: Provide task lists, status, guidance
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (4)
.cursor/rules/frontend.mdc (1)
12-12: Typographical error in guidelineThere’s a typo in the sentence:
- Change “New controllers shold be created in
frontend/src/controllersdirectory”
to “New controllers should be created infrontend/src/controllersdirectory.”.gitignore (1)
145-165: Review Task Master AI ignore sectionThe new section covers logs, IDE configs, and Task Master files. However, the placeholder comments for “Dependency directories” and “Environment variables” lack actual patterns. Please verify whether additional directories or files should be ignored, or remove these placeholders if they’re not needed.
.taskmaster/config.json (1)
1-31: Consider adding runtime validation for the configurationTo catch misconfigurations early, define a JSON Schema (e.g.,
config.schema.json) and validate.taskmaster/config.jsonduring startup or in CI. This will enforce required fields and correct types..cursor/rules/dev_workflow.mdc (1)
1-5: Consider adding version information to the frontmatter.The YAML frontmatter is well-structured but could benefit from version information to track documentation updates and ensure consistency across the workflow ecosystem.
--- description: Guide for using Task Master to manage task-driven development workflows +version: 1.0.0 +lastUpdated: 2024-12-19 globs: **/* alwaysApply: true ---
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
.cursor/rules/backend-error-handling.mdc(1 hunks).cursor/rules/backend-logging.mdc(1 hunks).cursor/rules/backend.mdc(1 hunks).cursor/rules/code-comments.mdc(0 hunks).cursor/rules/code-style.mdc(1 hunks).cursor/rules/cursor_rules.mdc(1 hunks).cursor/rules/dev_workflow.mdc(1 hunks).cursor/rules/frontend.mdc(1 hunks).cursor/rules/project-conventions.mdc(1 hunks).cursor/rules/self_improve.mdc(1 hunks).cursor/rules/taskmaster.mdc(1 hunks).cursor/rules/ui-ux-design-guidelines.mdc(1 hunks).gitignore(1 hunks).taskmaster/config.json(1 hunks).taskmaster/templates/example_prd.txt(1 hunks)
💤 Files with no reviewable changes (1)
- .cursor/rules/code-comments.mdc
🧰 Additional context used
🪛 LanguageTool
.taskmaster/templates/example_prd.txt
[grammar] ~29-~29: The past participle is required after “to be”.
Context: ... and detailing exactly what needs to be build in each phase so it can later be cut up...
(BE_VBP_IN)
🔇 Additional comments (15)
.cursor/rules/ui-ux-design-guidelines.mdc (1)
2-3: Missing description and globs metadata may disable rule applicationThe
description:andglobs:fields were cleared, which could prevent this rule from being applied. Please confirm whether empty globs are intentional (e.g., managed through a centralized config) or if specific patterns (e.g.,*.html,*.css,*.js) should be defined to target the intended files..cursor/rules/frontend.mdc (1)
2-3: Empty frontmatter metadata might unintentionally disable the ruleThe
description:andglobs:fields are now blank, and withalwaysApply: false, this rule may not match any files. Please verify whether globs are managed elsewhere or if you need to repopulate them (e.g.,*.js,*.html)..taskmaster/config.json (1)
1-31: Configuration structure looks soundThe JSON centralizes AI model parameters and global settings without exposing secrets. No syntax or schema errors detected.
.cursor/rules/code-style.mdc (1)
2-4: Clarify rule application scopeWith
globs:empty andalwaysApply: true, confirm that this style rule is intended to apply universally. If you only want it for certain file types (e.g.,.js,.ts,.py), please add the appropriate glob patterns..cursor/rules/backend-logging.mdc (1)
6-14: Excellent logging guidelines with practical examples.The logging rules are comprehensive and include practical examples with structlog. The emphasis on contextual logging and appropriate log levels will help maintain good observability practices.
.cursor/rules/project-conventions.mdc (2)
2-4: Verify the intentional metadata changes.The
descriptionfield has been cleared andalwaysApplychanged fromtruetofalse. Please confirm these changes are intentional as part of the cursor rules restructuring.These metadata changes may affect how and when this rule is applied. Consider whether:
- The description should remain empty or needs a new value
- The selective application (alwaysApply: false) aligns with the intended rule usage
6-86: Comprehensive project conventions documentation.The project conventions are well-documented and provide clear guidance on the tech stack, dependencies, architecture patterns, and testing approaches. The conventions promote maintainability and consistency across the codebase.
.cursor/rules/backend.mdc (2)
2-3: Verify the metadata field clearing.Similar to other files, the
descriptionandglobsfields have been cleared. Confirm this is intentional as part of the cursor rules restructuring.Consider whether these fields should have values or remain empty as part of the new rule organization strategy.
6-31: Well-focused backend development guidelines.The streamlined content effectively focuses on Django-specific backend practices, API development, and worker configuration. The separation of logging and error handling concerns into dedicated files improves the modularity of the rule system.
.taskmaster/templates/example_prd.txt (1)
1-47: Well-structured PRD template with comprehensive guidance.The template provides excellent structure for product requirements documentation, with clear separation between context and PRD sections. The guidance is thorough and actionable, covering all essential aspects from overview to technical architecture and risk assessment.
🧰 Tools
🪛 LanguageTool
[grammar] ~29-~29: The past participle is required after “to be”.
Context: ... and detailing exactly what needs to be build in each phase so it can later be cut up...(BE_VBP_IN)
.cursor/rules/cursor_rules.mdc (1)
1-54: Excellent foundational guidelines for Cursor rules.This document provides comprehensive and well-structured guidelines for creating and maintaining Cursor rules. The content covers all essential aspects including required structure, formatting conventions, file references, code examples, and maintenance practices. The document follows its own prescribed formatting standards and serves as an excellent reference for the other rule files in this PR.
.cursor/rules/self_improve.mdc (1)
7-72: Comprehensive framework for rule improvement.The content provides an excellent framework for continuously improving code quality rules. It covers all essential aspects including improvement triggers, analysis processes, update criteria, quality checks, and maintenance practices. The structured approach with clear examples and actionable guidance aligns well with the overall documentation standards.
.cursor/rules/taskmaster.mdc (1)
1-408: Comprehensive and well-structured Taskmaster reference documentation.This document provides excellent comprehensive coverage of all Taskmaster MCP tools and CLI commands. The structure is logical and well-organized, with clear sections for different functional areas. The parameter descriptions are detailed and include both MCP and CLI variants, usage examples, and important operational notes. The cross-references to other documentation files and proper frontmatter formatting align with the established guidelines.
.cursor/rules/dev_workflow.mdc (2)
107-123: Excellent configuration management documentation.The distinction between
.taskmaster/config.jsonfor primary configuration and environment variables for sensitive API keys is well-designed and clearly explained. The warning about not manually editing config files and the troubleshooting guidance for failed AI commands are particularly valuable.
177-230: Comprehensive iterative subtask implementation workflow.This section provides an excellent detailed workflow for implementing subtasks with proper logging, progress tracking, and rule updates. The emphasis on logging "what worked" and "what didn't work" is a great practice for knowledge retention and avoiding repeated mistakes.
The workflow correctly integrates with git practices and encourages comprehensive commit messages, which aligns with good software development practices.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Integrates Task Master AI for project management and establishes comprehensive development guidelines through new Cursor rules. The changes focus on standardizing development practices and workflow automation.
- Added Task Master AI configuration with
.taskmaster/config.jsonsupporting multiple AI providers (Google, Perplexity, Anthropic) for automated task management - Introduced structured backend guidelines in
/.cursor/rules/backend-logging.mdcand/.cursor/rules/backend-error-handling.mdcfor consistent logging and error handling - Added comprehensive development workflow guide in
/.cursor/rules/dev_workflow.mdcdetailing Task Master integration and usage - Established rule maintenance framework in
/.cursor/rules/self_improve.mdcfor keeping guidelines current - Standardized frontend development with Stimulus JS and TailwindCSS conventions in
/.cursor/rules/frontend.mdc
15 file(s) reviewed, 20 comment(s)
Edit PR Review Bot Settings | Greptile
| logger.warning( | ||
| "Error occurred during profile update", | ||
| error=str(e), | ||
| profile_id=profile.id | ||
| ) |
There was a problem hiding this comment.
style: Example shows raw string concatenation with str(e). Use structlog's built-in exception handling instead.
| # Dependency directories | ||
| # Environment variables |
There was a problem hiding this comment.
style: Empty section headers ('Dependency directories' and 'Environment variables') should be removed
|
|
||
| ## AI Model Configuration | ||
|
|
||
| ### 2. Manage Models (`models`) |
There was a problem hiding this comment.
logic: Duplicate section number '2' (first used for 'Parse PRD'). Should be '3. Manage Models'
| ### 2. Manage Models (`models`) | |
| ### 3. Manage Models (`models`) |
| * **CLI Command:** `task-master clear-subtasks [options]` | ||
| * **Description:** `Remove all subtasks from one or more specified Taskmaster parent tasks.` | ||
| * **Key Parameters/Options:** | ||
| * `id`: `The ID(s) of the Taskmaster parent task(s) whose subtasks you want to remove, e.g., '15' or '16,18'. Required unless using `all`.) (CLI: `-i, --id <ids>`) |
There was a problem hiding this comment.
syntax: Syntax error in backtick placement: all.) should be all`).
| * `id`: `The ID(s) of the Taskmaster parent task(s) whose subtasks you want to remove, e.g., '15' or '16,18'. Required unless using `all`.) (CLI: `-i, --id <ids>`) | |
| * `id`: `The ID(s) of the Taskmaster parent task(s) whose subtasks you want to remove, e.g., '15' or '16,18'. Required unless using all`). (CLI: `-i, --id <ids>`) |
| * `AZURE_OPENAI_API_KEY` (Requires `AZURE_OPENAI_ENDPOINT` too) | ||
| * `OPENROUTER_API_KEY` | ||
| * `XAI_API_KEY` | ||
| * `OLLANA_API_KEY` (Requires `OLLAMA_BASE_URL` too) |
There was a problem hiding this comment.
syntax: Typo in environment variable name: OLLANA_API_KEY should be OLLAMA_API_KEY
| * `OLLANA_API_KEY` (Requires `OLLAMA_BASE_URL` too) | |
| * `OLLAMA_API_KEY` (Requires `OLLAMA_BASE_URL` too) |
| [Break down the development process into phases: | ||
| - MVP requirements | ||
| - Future enhancements | ||
| - Do not think about timelines whatsoever -- all that matters is scope and detailing exactly what needs to be build in each phase so it can later be cut up into tasks] |
There was a problem hiding this comment.
syntax: 'build' should be 'built' in 'needs to be build'
| - Do not think about timelines whatsoever -- all that matters is scope and detailing exactly what needs to be build in each phase so it can later be cut up into tasks] | |
| - Do not think about timelines whatsoever -- all that matters is scope and detailing exactly what needs to be built in each phase so it can later be cut up into tasks] |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Shift local development ports for web (8000 to 8009), database (5432 to 5433), and Redis (6379 to 6380) in docker-compose.yml. Update corresponding port references in .env.example and README.md setup instructions. Add `restart: unless-stopped` to the mailpit service. Introduce the comprehensive Product Requirements Document (PRD) for the MarketingAgents platform in `.taskmaster/docs/prd.txt`. Delete the old PRD file located in the `scripts` directory. Add Bedrock Base URL and User ID fields to the .taskmaster/config.json file and add django-q logger configuration in settings.py for improved task queue logging. Include new `.cursor/mcp.json` file for Cursor IDE configuration and add the generated `task-complexity-report.json`.
Adds configuration for the Task Master AI MCP server and refactors the Cursor
rules documentation to support a task-driven development workflow using
Task Master.
Changes include:
.cursor/mcp.jsonto configure thetask-master-aiMCP serverand include necessary API keys.
.taskmaster/config.json) and anexample PRD template (
.taskmaster/templates/example_prd.txt)..gitignoreto exclude Task Master generated files and logs..cursor/rules/into more specific files:coding-conventions.mdctocode-comments.mdc.code style, general Cursor rule guidelines, development workflow
(focusing on Task Master), self-improvement/rule maintenance, and
a detailed Task Master tool/command reference.
backend.mdc,frontend.mdc,project-conventions.mdc,ui-ux-design-guidelines.mdc) to removespecific content (now in dedicated files) and adjusted their
alwaysApplyflags tofalseas they are now high-level guides.dev_workflow.mdcandtaskmaster.mdcrules provide detailedguidance on using Task Master, including MCP/CLI interactions, task
management, dependencies, complexity analysis, and the iterative
subtask implementation process.
cursor_rules.mdcprovides guidelines for writing and maintainingthe rule files themselves.
self_improve.mdcoutlines triggers and processes for patternrecognition and rule updates.
This update provides a more structured and documented approach to
development tasks and project conventions, tightly integrated with the
Task Master AI tool.
Summary by CodeRabbit
New Features
Chores
.gitignoreto cover additional log files, editor settings, and task management artifacts.Style
Refactor
Bug Fixes