Scroll Fix on Click Delete and Add Placeholder Feature#19
Open
chadwickmeyer wants to merge 6 commits intorauchg:masterfrom
Open
Scroll Fix on Click Delete and Add Placeholder Feature#19chadwickmeyer wants to merge 6 commits intorauchg:masterfrom
chadwickmeyer wants to merge 6 commits intorauchg:masterfrom
Conversation
If you want your "input" area to have placeholder text, like a normal input text field allows, this allows for that. When the area is clicked or if there are bit tags, the placeholder is hidden, like a normal placeholder. NOTE: this is different from the placeholder for the autocomplete, which is a useful, but different feature.
…ceholder Suggested Ability to have PlaceHolder
This is a joint merge that includes: - Prevent page from scrolling when you click the delete button on a bit tag. - Add ability to specify a pseduo placeholder on the "input" area, which disappears when you click in the field or when there are bit tags present.
They left, right, delete, and backspace keys were not working when used with Mootools 1.4.5. This upgrades the code to work with the changes to mootools. There may be a better way to do it, but it appeared that the old method for calling the code value for a specific key just didn't work anymore, e.g. `Event.Keys.left` didn't produce the right event.code, so I switched it to event.key and hard coded the values.
The old method used `Event.keys.up` to determine the correct `ev.code` for the key. But that doesn't work anymore evidently. So this fix hard codes the key name, and compares it with `ev.key` instead. NOTE: this may not be the most compatible method, but it was the quickest fix for my purposes and hopefully it will help someone else.
Remove the breaks in the switching case statement when checking the correct keys. Evidently only the 'previous' key should have a break for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a joint merge that includes: