Adds a second attempt to send the HTTP request in case of a network fail...#2
Merged
rauchy merged 7 commits intorauchy:masterfrom Dec 4, 2014
Merged
Conversation
Author
|
Hi Rauchy, |
Author
|
Can you take another look? |
lib/ringcaptcha.rb
Outdated
Owner
There was a problem hiding this comment.
Last comment I have, I promise!
Maybe it's better to have a 'tries' counter going backwards from 3 to 1, instead of a meaningless 'index' counter going from 1 to 3. Think about it, there's nothing 'index'-ish about this.
This way:
tries = 3
# ...
if tries > 0
# ...
Author
There was a problem hiding this comment.
I agree with the index name not being relevant for the use. Changed to attempts.
I want to keep the forward counter so I could use it in the sleep for creating the exponential growth.
rauchy
pushed a commit
that referenced
this pull request
Dec 4, 2014
Adds a second attempt to send the HTTP request in case of a network fail...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found few examples for HTTP failures causing SMS's sending failure.
This is a simple approach to reduce the chance for failure.