Conversation
rauchy
reviewed
Dec 1, 2016
lib/ringcaptcha/api_stub.rb
Outdated
| module Ringcaptcha | ||
| module APIStub | ||
| def self.call(api_key, app_key, path, params = {}) | ||
| if Ringcaptcha.use_instrumentation |
Owner
There was a problem hiding this comment.
This feels like asking instead of telling. Also this method eventually calls call_ringcaptcha, and the conditional here makes it feel like it does 2 separate things according to the value of use_instrumentation. It doesn't.
How about instead you call a block, something like
with_instrumentation do
call_ringcaptcha(api_key, app_key, path, params = {})
end
with_instrumentation will either instrument the block (if required), or simply yield it. WDYT?
Author
|
Changed. WDYT? |
Author
|
True :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instrumentation in order to enable logging