Merged
Conversation
- Replace check-then-create logic with atomic file creation using 'x' mode - Add retry loop with FileExistsError handling for collision recovery - Ensure next-release directory exists with os.makedirs - Prevents race conditions in concurrent environments
The next_release_path directory is already created in the constructor, making the os.makedirs call in create_changeset redundant and inefficient.
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
* Add test for concurrent changeset creation race condition Co-authored-by: raulgomis <raulgomis@gmail.com> * Add test for changeset file creation race condition Co-authored-by: raulgomis <raulgomis@gmail.com> * Fix race condition in changeset file creation Co-authored-by: raulgomis <raulgomis@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor create_changeset to prevent race conditions during file creation.
The previous create_changeset method was vulnerable to race conditions due to a check-then-create pattern (os.path.isfile then open). This PR fixes it by using open(..., 'x') for atomic, exclusive file creation within a retry loop to handle potential filename collisions. The redundant os.makedirs call was also removed as directory existence is ensured by the constructor.