Exception block static analyzer tool (RavenDB-3879)#1
Merged
ayende merged 6 commits intoravendb:masterfrom Jan 10, 2016
ElemarJR:ExceptionBlock
Merged
Exception block static analyzer tool (RavenDB-3879)#1ayende merged 6 commits intoravendb:masterfrom ElemarJR:ExceptionBlock
ayende merged 6 commits intoravendb:masterfrom
ElemarJR:ExceptionBlock
Conversation
ayende
added a commit
that referenced
this pull request
Jan 10, 2016
Exception block static analyzer tool (RavenDB-3879)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
This PR addresses the following scenarios:
empty catch blocks will generate a diagnostic asking for a properly implementation or comment
catch blocks with just logging (followed or not with a return or break statement) will generate a diagnostic asking for a comment
"try if not null dispose pattern" will not generate any diagnostic
catch blocks with ToDo Comments (TODO, HACK, UNDONE, FIXME) generates a diagnostic reporting this as a problem
This is it.