Skip to content

Enable additional mul_mat tests and add tensor data saving function#81

Merged
wine99 merged 2 commits intoravi9:dev_backend_openvinofrom
zhaixuejun1993:xuejun/enable_mul_mat_op_test
Mar 23, 2026
Merged

Enable additional mul_mat tests and add tensor data saving function#81
wine99 merged 2 commits intoravi9:dev_backend_openvinofrom
zhaixuejun1993:xuejun/enable_mul_mat_op_test

Conversation

@zhaixuejun1993
Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and bug fixes to the OpenVINO integration in the ggml project, focusing on tensor data handling, permute operation flexibility, and utility enhancements. The most notable changes include making the permute operation parameterizable, improving output tensor data copying, and adding a utility for exporting tensor data to text files.

OpenVINO Permute Operation Improvements:

  • The permute operation in permute.cpp now dynamically constructs the permutation vector based on operation parameters, allowing for more flexible and correct tensor transpositions instead of using a hardcoded permutation. (ggml/src/ggml-openvino/openvino/op/permute.cpp)
  • The check that previously marked all permute inputs as unsupported in is_op_unsupported_case has been removed, enabling support for more permute cases. (ggml/src/ggml-openvino/ggml-openvino.cpp)

Output Tensor Handling:

  • In the naive compute path, output tensors are now copied back to ggml tensors after inference, working around issues with set_output_tensor() and ensuring correct results. (ggml/src/ggml-openvino/utils.cpp)

Utility and Debugging Enhancements:

  • A new utility function, save_ggml_tensor_data_to_txt, has been added to export tensor data to a text file for easier debugging and inspection. (ggml/src/ggml-openvino/utils.cpp, ggml/src/ggml-openvino/utils.h) [1] [2]
  • Minor includes have been added to support new functionality. (ggml/src/ggml-openvino/openvino/op/permute.cpp, ggml/src/ggml-openvino/utils.cpp) [1] [2]…bugging

Make sure to read the contributing guidelines before submitting a PR

@wine99 wine99 merged commit 2d032d8 into ravi9:dev_backend_openvino Mar 23, 2026
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants