Enable additional mul_mat tests and add tensor data saving function#81
Merged
wine99 merged 2 commits intoravi9:dev_backend_openvinofrom Mar 23, 2026
Merged
Conversation
wine99
approved these changes
Mar 23, 2026
wine99
pushed a commit
that referenced
this pull request
Apr 8, 2026
wine99
pushed a commit
that referenced
this pull request
Apr 8, 2026
wine99
pushed a commit
that referenced
this pull request
Apr 8, 2026
wine99
pushed a commit
that referenced
this pull request
Apr 8, 2026
wine99
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the OpenVINO integration in the
ggmlproject, focusing on tensor data handling, permute operation flexibility, and utility enhancements. The most notable changes include making the permute operation parameterizable, improving output tensor data copying, and adding a utility for exporting tensor data to text files.OpenVINO Permute Operation Improvements:
permute.cppnow dynamically constructs the permutation vector based on operation parameters, allowing for more flexible and correct tensor transpositions instead of using a hardcoded permutation. (ggml/src/ggml-openvino/openvino/op/permute.cpp)is_op_unsupported_casehas been removed, enabling support for more permute cases. (ggml/src/ggml-openvino/ggml-openvino.cpp)Output Tensor Handling:
ggmltensors after inference, working around issues withset_output_tensor()and ensuring correct results. (ggml/src/ggml-openvino/utils.cpp)Utility and Debugging Enhancements:
save_ggml_tensor_data_to_txt, has been added to export tensor data to a text file for easier debugging and inspection. (ggml/src/ggml-openvino/utils.cpp,ggml/src/ggml-openvino/utils.h) [1] [2]ggml/src/ggml-openvino/openvino/op/permute.cpp,ggml/src/ggml-openvino/utils.cpp) [1] [2]…buggingMake sure to read the contributing guidelines before submitting a PR