Softened the cgroup devices controller and devtmpfs checks to maintain GKI compatibility#39
Merged
ravindu644 merged 3 commits intomainfrom Apr 8, 2026
Merged
Softened the cgroup devices controller and devtmpfs checks to maintain GKI compatibility#39ravindu644 merged 3 commits intomainfrom
ravindu644 merged 3 commits intomainfrom
Conversation
Owner
ravindu644
commented
Apr 8, 2026
ravindu644
commented
- Even in normal mode, we were forcefully checking and refusing to run Droidspaces, even though the non-hw-access mode doesn't require devtmpfs at all.
- From now on, we will only enforce devtmpfs mode if the user uses hardware access mode.
- Also, there's no point in hardcoding a check for legacy cgroup devices controller support if cgroupv2 support is present. We only need the cgroup devices controller in forced cgroupv1 mode anyway.
- By not enabling the cgroup devices controller in the GKI kernel, we have completely eliminated ABI breakage, allowing Droidspaces to run on the GKI kernel without breaking the ABI, which is a big deal.
… for the hardware access mode Signed-off-by: ravindu644 <droidcasts@protonmail.com>
…roupv2 Signed-off-by: ravindu644 <droidcasts@protonmail.com>
…ices checks in check.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.