security: restrict daemon access to root and 'droidspaces' group#98
Merged
Conversation
Abstract sockets do not respect standard filesystem permissions, which
previously allowed any local user to connect to the daemon. This patch
secures the daemon by enforcing identity verification via SO_PEERCRED.
Access is now restricted to:
- The root user (UID 0)
- Members of the 'droidspaces' group
Membership is verified using getgrouplist() to ensure all secondary
groups are checked. This allows running droidspaces without sudo by
setting up the group as follows:
groupadd droidspaces
sudo usermod -aG droidspaces $USER
Unauthorized users will now receive a "permission denied" message
before the connection is terminated.
Co-authored-by: Josh Law <joshlaw48@gmail.com>
Co-authored-by: Yoshinobu Date <yoshinobu.em@gmail.com>
Signed-off-by: ravindu644 <droidcasts@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract sockets do not respect standard filesystem permissions, which previously allowed any local user to connect to the daemon. This patch secures the daemon by enforcing identity verification via SO_PEERCRED.
Access is now restricted to:
Membership is verified using getgrouplist() to ensure all secondary groups are checked. This allows running droidspaces without sudo by setting up the group as follows:
Unauthorized users will now receive a "permission denied" message before the connection is terminated.