Fix type missmatch for set_opts functions#41
Merged
rawhat merged 2 commits intorawhat:masterfrom Mar 5, 2026
Merged
Conversation
Contributor
|
Since the reason type returned by Erlang for ssl:setopts is defines as just |
Owner
|
I wish there was a more well-defined list of errors we could get here. It kinda sucks to lose the context here, even if it's just being discarded most of the time. I do think this is more accurate, but I was leaving this open-ended to potentially eventually actually expose these. But I think that can be a problem to solve later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #40 (comment)