on_close with CloseReason #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @rawhat! This has been sitting there for a while and I really wanna publish a library that actually makes use of this feature. Please review if you could :) |
folospior
force-pushed
the
new_on_close
branch
from
e72ae87 to
f1bb23f
Compare
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR!
This PR allows for getting close codes when the connection is closed by the server (in the on_close function)
I'm still not sure about the API, since it shares the same constructor as sending a custom close code, so as a workaround I created the
get_custom_codeandget_custom_bodyfunctions, which are kinda eh in my opinion, so please do share yours about this. Perhaps turning it into a tuple of#(Int, BitArray)🤔