Skip to content

fix(element-wrapper): handle null case for XmlSeeAlso parameter array initialization #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rawvoid merged 5 commits into from
Jan 23, 2026
Merged

fix(element-wrapper): handle null case for XmlSeeAlso parameter array initialization #32

rawvoid merged 5 commits into from
Jan 23, 2026

Conversation

@rawvoid
Copy link
Owner

@rawvoid rawvoid commented Jan 23, 2026

Summary

This PR fixes a null pointer exception issue that could occur during XmlSeeAlso parameter array initialization. The fix ensures proper null handling when processing XmlSeeAlso annotations in the ElementWrapperPlugin.

Problem Identified

  • Null Safety Issue: XmlSeeAlso parameter array initialization could encounter null values
  • Potential NPE: Null values in XmlSeeAlso processing could cause runtime exceptions
  • Edge Case Handling: Missing null checks for robust error handling

Technical Fix

  • Null Check Added: Implemented proper null validation before array initialization
  • Safe Processing: Enhanced XmlSeeAlso processing to handle null parameters gracefully
  • Minimal Change: Focused fix with 3 insertions and 1 deletion in ElementWrapperPlugin.java

Impact

  • Improved Reliability: Eliminates potential NPE during XmlSeeAlso processing
  • Better Error Handling: Graceful handling of edge cases without crashing
  • Production Stability: Reduces risk of runtime failures in production environments

Files Changed

  • plugins/src/main/java/io/github/rawvoid/jaxb/plugin/ElementWrapperPlugin.java

@rawvoid
feat(element-wrapper): enhance wrapper class detection and removal logic
6020a7a 
Improved detection of wrapper classes and added safeguards to prevent removal of classes with active references or nested classes.
@rawvoid
feat(element-wrapper): add logging for wrapper class removal and skip…
c4d04d5 
…ped classes

Integrated SLF4J logging to record removed and skipped wrapper classes in `ElementWrapperPlugin`. Updated dependencies to include SLF4J.
@rawvoid
docs(element-wrapper): add detailed documentation for wrapper handlin…
4517306 
…g methods

Enhanced `ElementWrapperPlugin` with extensive Javadoc comments, improving clarity for annotation migration, wrapper detection, and field handling logic.
@rawvoid
fix(element-wrapper): ensure complete removal of unused wrapper classes
2d3824b 
- Fix incomplete removal of wrapper classes in ElementWrapperPlugin
- Improve reference checking logic in removeWrapperClass method to identify all usages
- Enhance debug output formatting for better readability
@rawvoid
fix(element-wrapper): handle null case for XmlSeeAlso parameter arr…
baa3e8f 
…ay initialization
@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 23, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rawvoid rawvoid merged commit a39164d into main Jan 23, 2026
4 checks passed
@rawvoid rawvoid deleted the pr/wrapper-xmlseealso-fix branch January 31, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rawvoid