[Prometheus] Add ray_services_created_total metric
#3224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
commented
Mar 25, 2025
Comment on lines
135
to
137
| if len(rayServiceInstance.Status.Conditions) == 0 { | ||
| common.CreatedRayServicesCounterInc(rayServiceInstance.Namespace) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
The if statement is used to avoid recording duplicate metrics.
Collaborator
Author
|
@troychiu PTAL, thx. |
win5923
force-pushed
the
metrics/ray_services_created_total
branch
from
5ad9846 to
469cade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add
ray_services_created_totalmetric to track the total number of RayServices createdManual test
Related issue number
Closes #3176
Checks