Update Arrow Package with breaking changes#2440
Conversation
|
@pcmoritz Hi Philipp, there are 2 breaking changes in Arrow Plasma. I'm doing some [WIP] test but found there are conflicts. Could you please give a quick review to unblock my work? |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
@robertnishihara Could you help to review? |
|
Thanks @guoyuhong! @pcmoritz or I will be able to take a look later tonight. |
|
I'm reviewing it now, sorry for the delay! |
|
Test FAILed. |
src/plasma/plasma_manager.h
Outdated
There was a problem hiding this comment.
In https://github.com/apache/arrow/pull/2282/files , this file is removed from the installation list, so this file is not available now.
There was a problem hiding this comment.
oh yeah, it's a new file with forward declarations that I forgot to add :)
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
pcmoritz
left a comment
There was a problem hiding this comment.
+1 Thanks for doing this!
What do these changes do?
There are 2 breaking changes in Arrow Plasma: apache/arrow#2242 and apache/arrow#2282.
Two header files are unavailable now:
plasma.handprotocol.h, but theplasma_managerneeds them. I did following things to make this updating smooth.plasma.fbsfrom ray: instead, we will copyplasma.fbsandcommon.fbsfrom Arrow, which will avoid duplication.plasma_managerthat declared inprotocol.hwhich we cannot use now.Related issue number