[RLlib] Add evaluation worker healthiness stats only if eval worker is not None#30384
Merged
gjoliver merged 1 commit intoray-project:masterfrom Nov 17, 2022
Merged
Conversation
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
kouroshHakha
requested review from
ArturNiederfahrenhorst,
avnishn,
gjoliver,
krfricke,
maxpumperla,
smorad and
sven1977
as code owners
gjoliver
approved these changes
Nov 17, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com> Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kourosh Hakhamaneshi kourosh@anyscale.com
Why are these changes needed?
It fixes a bug where we attempt to access self.evaluation_workers for returning stats when it's None.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.