Fix various issues with test_rollout_worker.py when connector is enabled#30386
Merged
gjoliver merged 2 commits intoray-project:masterfrom Nov 17, 2022
Merged
Conversation
gjoliver
requested review from
ArturNiederfahrenhorst,
avnishn,
kouroshHakha,
krfricke,
maxpumperla,
smorad and
sven1977
as code owners
| self.assertEqual(result["episode_reward_mean"], 1000) | ||
| # Shows different behavior when connector is on/off. | ||
| if config.enable_connectors: | ||
| # episode_reward_mean shows the correct clipped value. |
Contributor
There was a problem hiding this comment.
Where did we clip before? In algorithm?
Member
Author
There was a problem hiding this comment.
somewhere random man.
as soon as I see this, I was like "let's get this finished and turned on" :)
| self.training_enabled = training_enabled | ||
|
|
||
| def step(self, action): | ||
| obs, rew, done, info = super(NoTrainingEnv, self).step(action) |
Contributor
There was a problem hiding this comment.
This syntax was enabled with Python 3.0. I wonder why it's not part of linters for modern Python projects.
ArturNiederfahrenhorst
approved these changes
Nov 17, 2022
Contributor
ArturNiederfahrenhorst
left a comment
ArturNiederfahrenhorst
left a comment
There was a problem hiding this comment.
Great stuff man! Thanks a bunch 👍
added 2 commits
November 16, 2022 19:44
…led. Signed-off-by: Jun Gong <jungong@anyscale.com>
gjoliver
force-pushed
the
connector_rollout_worker_test
branch
from
be490b2 to
469de7e
Compare
gjoliver
added
the
tests-ok
Member
Author
|
looked at all the test failures. they are known to be broken in master. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…led (ray-project#30386) Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Gong jungong@anyscale.com
Why are these changes needed?
Fix test_rollout_worker.py
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.