[Runtime Env] Fix filelock deadlock round 2#30425
Merged
simon-mo merged 5 commits intoray-project:masterfrom Nov 18, 2022
Merged
[Runtime Env] Fix filelock deadlock round 2#30425simon-mo merged 5 commits intoray-project:masterfrom
simon-mo merged 5 commits intoray-project:masterfrom
Conversation
Signed-off-by: simon-mo <simon.mo@hey.com>
…ime-env/fix-deadlock
…to runtime-env/fix-deadlock
architkulkarni
approved these changes
Nov 17, 2022
Contributor
|
@simon-mo I didn't catch the bug in the previous implementation, what was it? |
Contributor
Author
|
|
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The previous PR #30371 didn't work on Python 3.6 because the
_blockingflag is new and didn't release on 3.6 version. I also fixed a minor bug in the implementation.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.