[release][no_ci] Mark tf mnist gpu benchmark test as unstable.#30475
Merged
amogkam merged 1 commit intoray-project:masterfrom Nov 18, 2022
Merged
[release][no_ci] Mark tf mnist gpu benchmark test as unstable.#30475amogkam merged 1 commit intoray-project:masterfrom
amogkam merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
amogkam
approved these changes
Nov 18, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…roject#30475) Mark weekly tf mnist gpu benchmark test as unstable. For the following reason: - The nightly counterpart is already marked unstable. - The test has a pretty high chance of timing out (since the day it was written) when acquiring vanilla tf time (20% of the time). It seems to be a native issue from distributed tf. Hence we don't have a reliable way of acquiring vanilla tf time leading to the test flakiness. - Since updating cuda version, both air timing and vanilla tf timing have increased greatly from 400+ to 800+ for 200 epochs. Currently I don't have a good understanding of why that's the case. But this just makes the whole test even more likely to time out. - Overall, the test is not providing much signal as to how AIR is doing compared to vanilla tf. Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xwjiang2010 xwjiang2010@gmail.com
Why are these changes needed?
Mark weekly tf mnist gpu benchmark test as unstable.
For the following reason:
Overall, the test is not providing much signal as to how AIR is doing compared to vanilla tf.
See more details in #29922.
Related issue number
#29922
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.